Skip to content

Conversation

@carsonwang
Copy link
Contributor

The log page should only show desired length of bytes. Currently it shows bytes from the startIndex to the end of the file. The "Next" button on the page is always disabled.

@srowen
Copy link
Member

srowen commented Jun 4, 2015

Jenkins, add to whitelist

@srowen
Copy link
Member

srowen commented Jun 4, 2015

ok to test

@SparkQA
Copy link

SparkQA commented Jun 4, 2015

Test build #34182 has finished for PR 6640 at commit 58cb3fd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jun 4, 2015

Yeah, given the code here, it seems like math.min(startIndex + totalLength, totalLength) has to be a typo. CC @tdas just in case

@tdas
Copy link
Contributor

tdas commented Jun 4, 2015

YES. LGTM. Merging it. Thanks for catching this.

asfgit pushed a commit that referenced this pull request Jun 4, 2015
The log page should only show desired length of bytes. Currently it shows bytes from the startIndex to the end of the file. The "Next" button on the page is always disabled.

Author: Carson Wang <carson.wang@intel.com>

Closes #6640 from carsonwang/logpage and squashes the following commits:

58cb3fd [Carson Wang] Show correct length of bytes on log page

(cherry picked from commit 63bc0c4)
Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com>
asfgit pushed a commit that referenced this pull request Jun 4, 2015
The log page should only show desired length of bytes. Currently it shows bytes from the startIndex to the end of the file. The "Next" button on the page is always disabled.

Author: Carson Wang <carson.wang@intel.com>

Closes #6640 from carsonwang/logpage and squashes the following commits:

58cb3fd [Carson Wang] Show correct length of bytes on log page

(cherry picked from commit 63bc0c4)
Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com>
@asfgit asfgit closed this in 63bc0c4 Jun 4, 2015
@carsonwang carsonwang deleted the logpage branch June 9, 2015 06:39
jeanlyn pushed a commit to jeanlyn/spark that referenced this pull request Jun 12, 2015
The log page should only show desired length of bytes. Currently it shows bytes from the startIndex to the end of the file. The "Next" button on the page is always disabled.

Author: Carson Wang <carson.wang@intel.com>

Closes apache#6640 from carsonwang/logpage and squashes the following commits:

58cb3fd [Carson Wang] Show correct length of bytes on log page
nemccarthy pushed a commit to nemccarthy/spark that referenced this pull request Jun 19, 2015
The log page should only show desired length of bytes. Currently it shows bytes from the startIndex to the end of the file. The "Next" button on the page is always disabled.

Author: Carson Wang <carson.wang@intel.com>

Closes apache#6640 from carsonwang/logpage and squashes the following commits:

58cb3fd [Carson Wang] Show correct length of bytes on log page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants