Skip to content

[DOC][Minor]Specify the common sources available for collecting #6641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yjshen wants to merge 2 commits into from
Closed

[DOC][Minor]Specify the common sources available for collecting #6641

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f23140c
[DOC][Minor]Specify the common sources available for collecting
yjshen Jun 4, 2015
b5b99b4
Make it clear that JvmSource is the only available additional source …
yjshen Jun 4, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions conf/metrics.properties.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# divided into instances which correspond to internal components.
# Each instance can be configured to report its metrics to one or more sinks.
# Accepted values for [instance] are "master", "worker", "executor", "driver",
# and "applications". A wild card "*" can be used as an instance name, in
# and "applications". A wildcard "*" can be used as an instance name, in
# which case all instances will inherit the supplied property.
#
# Within an instance, a "source" specifies a particular set of grouped metrics.
Expand Down Expand Up @@ -32,7 +32,7 @@
# name (see examples below).
# 2. Some sinks involve a polling period. The minimum allowed polling period
# is 1 second.
# 3. Wild card properties can be overridden by more specific properties.
# 3. Wildcard properties can be overridden by more specific properties.
# For example, master.sink.console.period takes precedence over
# *.sink.console.period.
# 4. A metrics specific configuration
Expand All @@ -47,6 +47,13 @@
# instance master and applications. MetricsServlet may not be configured by self.
#

## List of available common sources and their properties.

# org.apache.spark.metrics.source.JvmSource
Copy link
Member

@srowen srowen Jun 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't the only Source, and this doesn't document anything about it. What's the value?

Copy link
Member Author

@yjshen yjshen Jun 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the only Common Source users can add additionally, all the spark internal source are added automatically.
No value for this one, just as org.apache.spark.metrics.sink.JmxSink.

# Note: Currently, JvmSource is the only available common source
# to add additionaly to an instance, to enable this,
# set the "class" option to its fully qulified class name (see examples below)

## List of available sinks and their properties.

# org.apache.spark.metrics.sink.ConsoleSink
Expand Down