Skip to content

[SPARK-8119][Scheduler]Do not let Spark set total executors when executor fails #6662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SaintBacchus wants to merge 2 commits into from
Closed

[SPARK-8119][Scheduler]Do not let Spark set total executors when executor fails #6662

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
610c390
[SPARK-8119][Scheduler]Do not let Spark set total executors when exec…
SaintBacchus Jun 5, 2015
016214d
Code format
SaintBacchus Jun 5, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion core/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,10 @@ private[spark] abstract class YarnSchedulerBackend(
* This includes executors already pending or running.
*/
override def doRequestTotalExecutors(requestedTotal: Int): Boolean = {
yarnSchedulerEndpoint.askWithRetry[Boolean](RequestExecutors(requestedTotal))
if (conf.getBoolean("spark.dynamicAllocation.enabled", false)) {
Copy link
Contributor

@vanzin vanzin Jun 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain how this method is called with dynamic allocation disabled?

The only call chain I can find starts with ExecutorAllocationManager, which is not instantiated when dynamic allocation is off.

Copy link
Contributor

@andrewor14 andrewor14 Jun 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can do sc.requestTotalExecutors

Copy link
Contributor

@vanzin vanzin Jun 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean:

private[spark] override def requestTotalExecutors

I don't see any calls to it, and given it's private[spark]...

Copy link
Contributor

@andrewor14 andrewor14 Jun 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I meant sc.requestExecutors, which eventually calls the method here.

return yarnSchedulerEndpoint.askWithRetry[Boolean](RequestExecutors(requestedTotal))
}
false
}

/**
Expand Down