Skip to content

Conversation

@RoyGao
Copy link
Contributor

@RoyGao RoyGao commented Jun 5, 2015

I have added unit test for ML's StandardScaler By comparing with R's output, please review for me.
Thx.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please extend SparkFunSuite instead (we added some tools to help Jenkins logging).

@mengxr
Copy link
Contributor

mengxr commented Jun 6, 2015

ok to test

@SparkQA
Copy link

SparkQA commented Jun 6, 2015

Test build #34379 has finished for PR 6665 at commit b3dfd4a.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class StandardScalerSuite extends FunSuite with MLlibTestSparkContext

@SparkQA
Copy link

SparkQA commented Jun 8, 2015

Test build #34426 has finished for PR 6665 at commit 4980835.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class StandardScalerSuite extends SparkFunSuite with MLlibTestSparkContext

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe checkParams?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAVER - http://www.naver.com/

sujkh@naver.com 님께 보내신 메일 <Re: [spark] [SPARK-7013][ML][test]Add unit test for spark.ml StandardScaler (#6665)> 이 다음과 같은 이유로 전송 실패했습니다.


받는 사람이 회원님의 메일을 수신차단 하였습니다.


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add it in a separate PR.

@mengxr
Copy link
Contributor

mengxr commented Nov 17, 2015

ok to test

@mengxr
Copy link
Contributor

mengxr commented Nov 17, 2015

LGTM pending Jenkins.

@SparkQA
Copy link

SparkQA commented Nov 17, 2015

Test build #46118 has finished for PR 6665 at commit 4980835.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * class StandardScalerSuite extends SparkFunSuite with MLlibTestSparkContext\n

asfgit pushed a commit that referenced this pull request Nov 18, 2015
I have added unit test for ML's StandardScaler By comparing with R's output, please review  for me.
Thx.

Author: RoyGaoVLIS <roygao@zju.edu.cn>

Closes #6665 from RoyGao/7013.

(cherry picked from commit 67a5132)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@mengxr
Copy link
Contributor

mengxr commented Nov 18, 2015

Merged into master and branch-1.6. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants