Skip to content

Conversation

@MechCoder
Copy link
Contributor

Add Python bindings to StreamingLogisticRegressionwithSGD.

No Java wrappers are needed as models are updated directly using train.

@MechCoder MechCoder changed the title [SPARK-3258] [MLlib] [PySpark] Python bindings for StreamingLogisticRegressionwithSGD [SPARK-7633] [MLlib] [PySpark] Python bindings for StreamingLogisticRegressionwithSGD Jun 16, 2015
@SparkQA
Copy link

SparkQA commented Jun 16, 2015

Test build #35005 has finished for PR 6849 at commit 7bd6a46.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class StreamingLogisticRegressionWithSGD(object):

@SparkQA
Copy link

SparkQA commented Jun 16, 2015

Test build #35002 timed out for PR 6849 at commit 0e2fe86 after a configured wait of 175m.

@MechCoder
Copy link
Contributor Author

jenkins retest this please

@MechCoder
Copy link
Contributor Author

cc @freeman-lab :P

@SparkQA
Copy link

SparkQA commented Jun 17, 2015

Test build #35019 has finished for PR 6849 at commit 7bd6a46.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class StreamingLogisticRegressionWithSGD(object):

@SparkQA
Copy link

SparkQA commented Jun 20, 2015

Test build #35358 has finished for PR 6849 at commit 5a94db0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class StreamingLogisticRegressionWithSGD(object):

@MechCoder
Copy link
Contributor Author

@mengxr Could you review this? This should be the next one to go as I have refactored the code.

@SparkQA
Copy link

SparkQA commented Jun 20, 2015

Test build #35363 has finished for PR 6849 at commit 19c0f25.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class StreamingLinearAlgorithm(object):
    • class StreamingLogisticRegressionWithSGD(StreamingLinearAlgorithm):

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

organize imports

@mengxr
Copy link
Contributor

mengxr commented Jun 23, 2015

@MechCoder I need to make another pass on the code and tests after your update. Please make sure the tests are the same as the ones on the Scala side.

@MechCoder
Copy link
Contributor Author

@mengxr Thanks for the updates! I confirm that the tests are very similar

@SparkQA
Copy link

SparkQA commented Jun 24, 2015

Test build #35688 has finished for PR 6849 at commit bdab425.

  • This patch fails MiMa tests.
  • This patch does not merge cleanly.
  • This patch adds the following public classes (experimental):
    • class StreamingLinearAlgorithm(object):
    • class StreamingLogisticRegressionWithSGD(StreamingLinearAlgorithm):

@SparkQA
Copy link

SparkQA commented Jun 24, 2015

Test build #35689 has finished for PR 6849 at commit 5c4305c.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class StreamingLinearAlgorithm(object):
    • class StreamingLogisticRegressionWithSGD(StreamingLinearAlgorithm):

@MechCoder
Copy link
Contributor Author

I have rerun the tests. (Strange that the tests that failed in the previous run were related to StreamingKMeans)

@SparkQA
Copy link

SparkQA commented Jun 24, 2015

Test build #35699 has finished for PR 6849 at commit b4376a5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class StreamingLinearAlgorithm(object):
    • class StreamingLogisticRegressionWithSGD(StreamingLinearAlgorithm):

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@mengxr
Copy link
Contributor

mengxr commented Jun 24, 2015

@MechCoder The streaming k-means tests seem to be flaky. Could you run it multiple times on your local?

@MechCoder
Copy link
Contributor Author

Sure, btw the last failure was some random error.

@MechCoder
Copy link
Contributor Author

@mengxr Could you give another pass? I can update tomorrow, there is some problem with my ubunt.

@asfgit asfgit closed this in fb32c38 Jun 24, 2015
@mengxr
Copy link
Contributor

mengxr commented Jun 24, 2015

LGTM. Merged into master. I think the streaming k-means test might be flaky, which is usually hard to debug. Let's watch Jenkins master build: https://amplab.cs.berkeley.edu/jenkins/job/Spark-Master-SBT and see if there are failures.

@MechCoder MechCoder deleted the spark-3258 branch June 25, 2015 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants