-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-7633] [MLlib] [PySpark] Python bindings for StreamingLogisticRegressionwithSGD #6849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #35005 has finished for PR 6849 at commit
|
|
Test build #35002 timed out for PR 6849 at commit |
|
jenkins retest this please |
|
cc @freeman-lab :P |
|
Test build #35019 has finished for PR 6849 at commit
|
|
Test build #35358 has finished for PR 6849 at commit
|
|
@mengxr Could you review this? This should be the next one to go as I have refactored the code. |
|
Test build #35363 has finished for PR 6849 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
organize imports
|
@MechCoder I need to make another pass on the code and tests after your update. Please make sure the tests are the same as the ones on the Scala side. |
|
@mengxr Thanks for the updates! I confirm that the tests are very similar |
|
Test build #35688 has finished for PR 6849 at commit
|
|
Test build #35689 has finished for PR 6849 at commit
|
|
I have rerun the tests. (Strange that the tests that failed in the previous run were related to StreamingKMeans) |
|
Test build #35699 has finished for PR 6849 at commit
|
|
Merged build finished. Test FAILed. |
|
@MechCoder The streaming k-means tests seem to be flaky. Could you run it multiple times on your local? |
|
Sure, btw the last failure was some random error. |
|
@mengxr Could you give another pass? I can update tomorrow, there is some problem with my ubunt. |
|
LGTM. Merged into master. I think the streaming k-means test might be flaky, which is usually hard to debug. Let's watch Jenkins master build: https://amplab.cs.berkeley.edu/jenkins/job/Spark-Master-SBT and see if there are failures. |
Add Python bindings to StreamingLogisticRegressionwithSGD.
No Java wrappers are needed as models are updated directly using train.