Skip to content

Conversation

@yu-iskw
Copy link
Contributor

@yu-iskw yu-iskw commented Jun 22, 2015

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Jun 22, 2015

@shivaram Could you review it when you have time? Thanks!

@SparkQA
Copy link

SparkQA commented Jun 22, 2015

Test build #35487 has finished for PR 6941 at commit c196173.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class NGram(override val uid: String)

R/pkg/R/column.R Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we don't need the createInOperator function -- You can just add the setMethod below after cast etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I will modify soon. Thanks.

@shivaram
Copy link
Contributor

cc @falaki @davies

@SparkQA
Copy link

SparkQA commented Jun 22, 2015

Test build #35488 has finished for PR 6941 at commit 6e37936.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class NGram(override val uid: String)

@SparkQA
Copy link

SparkQA commented Jun 22, 2015

Test build #35490 has finished for PR 6941 at commit f4309a7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class NGram(override val uid: String)

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Jun 23, 2015

@shivaram I modified the position of setMethod for %in% operator. Could you review it?

R/pkg/R/column.R Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you write a slightly more detailed description of what this operator does ? It will be great to also have a short example (similar to what we have for cast)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

@SparkQA
Copy link

SparkQA commented Jun 23, 2015

Test build #35517 has finished for PR 6941 at commit 1f64423.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Merged build finished. Test FAILed.

@davies
Copy link
Contributor

davies commented Jun 23, 2015

LGTM, merged into master, thanks!

@asfgit asfgit closed this in d4f6335 Jun 23, 2015
@yu-iskw
Copy link
Contributor Author

yu-iskw commented Jun 23, 2015

@davies Thank you for merging it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants