Skip to content

Conversation

@zsxwing
Copy link
Member

@zsxwing zsxwing commented Jun 23, 2015

This PR adds the Python API for Kinesis, including a Python example and a simple unit test.

python/run-tests Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to move this logic into pyspark/streaming/test.py's main method instead? I'm in the middle of a Python test runner refactoring and it would greatly simplify things if the test suites themselves enforced that their prerequisites were installed rather than pushing that responsibility into the test triggering script.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw your refactoring work. I will update it once your PR is merged.

@SparkQA
Copy link

SparkQA commented Jun 23, 2015

Test build #35554 has finished for PR 6955 at commit 4957c0b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class KinesisUtils(object):
    • class InitialPositionInStream(object):

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version is never used in the error message. This fails with:
TypeError: not all arguments converted during string formatting

@SparkQA
Copy link

SparkQA commented Jul 23, 2015

Test build #38223 has finished for PR 6955 at commit 687446b.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class KinesisUtils(object):
    • class InitialPositionInStream(object):

@SparkQA
Copy link

SparkQA commented Jul 23, 2015

Test build #38230 has finished for PR 6955 at commit 466b425.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 23, 2015

Test build #38236 has finished for PR 6955 at commit 7c5cfb0.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 24, 2015

Test build #38312 has finished for PR 6955 at commit 6c37395.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class KinesisUtils(object):
    • class InitialPositionInStream(object):

@SparkQA
Copy link

SparkQA commented Jul 24, 2015

Test build #38341 has finished for PR 6955 at commit 96670ff.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class KinesisUtils(object):
    • class InitialPositionInStream(object):

@SparkQA
Copy link

SparkQA commented Jul 24, 2015

Test build #38353 has finished for PR 6955 at commit bcefc6e.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class KinesisUtils(object):
    • class InitialPositionInStream(object):

@SparkQA
Copy link

SparkQA commented Jul 25, 2015

Test build #38416 has finished for PR 6955 at commit b810127.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class KinesisUtils(object):
    • class InitialPositionInStream(object):

@SparkQA
Copy link

SparkQA commented Jul 25, 2015

Test build #38426 has finished for PR 6955 at commit fca416b.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class KinesisUtils(object):
    • class InitialPositionInStream(object):

@zsxwing
Copy link
Member Author

zsxwing commented Jul 25, 2015

retest this please

@SparkQA
Copy link

SparkQA commented Jul 25, 2015

Test build #100 has finished for PR 6955 at commit fca416b.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class KinesisUtils(object):
    • class InitialPositionInStream(object):

@SparkQA
Copy link

SparkQA commented Jul 25, 2015

Test build #38433 has finished for PR 6955 at commit fca416b.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class KinesisUtils(object):
    • class InitialPositionInStream(object):

@SparkQA
Copy link

SparkQA commented Jul 26, 2015

Test build #38449 timed out for PR 6955 at commit 5082d28 after a configured wait of 175m.

@zsxwing
Copy link
Member Author

zsxwing commented Jul 26, 2015

retest this please

@SparkQA
Copy link

SparkQA commented Jul 26, 2015

Test build #104 has finished for PR 6955 at commit 5082d28.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class KinesisUtils(object):
    • class InitialPositionInStream(object):

@tdas
Copy link
Contributor

tdas commented Jul 30, 2015

@zsxwing could you update this PR by merging with the master. And you probably need to add the environment variable thing to the new module.

@SparkQA
Copy link

SparkQA commented Jul 30, 2015

Test build #39028 has finished for PR 6955 at commit 5082d28.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class KinesisUtils(object):
    • class InitialPositionInStream(object):

@tdas
Copy link
Contributor

tdas commented Jul 30, 2015

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Jul 30, 2015

Test build #39032 has finished for PR 6955 at commit 455f7ea.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 30, 2015

Test build #39038 has finished for PR 6955 at commit 455f7ea.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • public static final class FloatPrefixComparator extends PrefixComparator
    • class KinesisUtils(object):
    • class InitialPositionInStream(object):
    • case class UnsafeExternalSort(

@SparkQA
Copy link

SparkQA commented Jul 30, 2015

Test build #1240 has finished for PR 6955 at commit 455f7ea.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@tdas
Copy link
Contributor

tdas commented Jul 31, 2015

LGTM. I will merge this when this build passes.

@SparkQA
Copy link

SparkQA commented Jul 31, 2015

Test build #39127 timed out for PR 6955 at commit e42e471 after a configured wait of 175m.

@zsxwing
Copy link
Member Author

zsxwing commented Jul 31, 2015

retest this please

@SparkQA
Copy link

SparkQA commented Jul 31, 2015

Test build #173 has finished for PR 6955 at commit e42e471.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 31, 2015

Test build #39149 has finished for PR 6955 at commit e42e471.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class KinesisUtils(object):
    • class InitialPositionInStream(object):

@zsxwing
Copy link
Member Author

zsxwing commented Jul 31, 2015

retest this please

@SparkQA
Copy link

SparkQA commented Jul 31, 2015

Test build #174 has started for PR 6955 at commit e42e471.

@SparkQA
Copy link

SparkQA commented Jul 31, 2015

Test build #39175 has finished for PR 6955 at commit e42e471.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class KinesisUtils(object):
    • class InitialPositionInStream(object):

@zsxwing
Copy link
Member Author

zsxwing commented Jul 31, 2015

retest this please

@SparkQA
Copy link

SparkQA commented Jul 31, 2015

Test build #1255 has finished for PR 6955 at commit e42e471.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zsxwing
Copy link
Member Author

zsxwing commented Jul 31, 2015

retest this please

@SparkQA
Copy link

SparkQA commented Jul 31, 2015

Test build #176 has finished for PR 6955 at commit e42e471.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class KinesisUtils(object):
    • class InitialPositionInStream(object):

@SparkQA
Copy link

SparkQA commented Jul 31, 2015

Test build #39201 has finished for PR 6955 at commit e42e471.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class KinesisUtils(object):
    • class InitialPositionInStream(object):

@SparkQA
Copy link

SparkQA commented Jul 31, 2015

Test build #177 has finished for PR 6955 at commit e42e471.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 31, 2015

Test build #39205 has finished for PR 6955 at commit e42e471.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class KinesisUtils(object):
    • class InitialPositionInStream(object):

@zsxwing
Copy link
Member Author

zsxwing commented Jul 31, 2015

Test build #177 has finished for PR 6955 at commit e42e471.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

@tdas looks SlowSparkPullRequestBuilder doesn't have the AWS keys.

@tdas
Copy link
Contributor

tdas commented Jul 31, 2015

Yeah, it does not. Other tests passed, so I am merging this to master. Thanks!

@asfgit asfgit closed this in 3afc1de Jul 31, 2015
@zsxwing zsxwing deleted the kinesis-python branch August 1, 2015 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants