Skip to content

[SPARK-8802] [WIP] [SQL] Decimal.apply(BigDecimal).toBigDecimal may throw NumberFormatException #7198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshRosen wants to merge 1 commit into from
Closed

[SPARK-8802] [WIP] [SQL] Decimal.apply(BigDecimal).toBigDecimal may throw NumberFormatException #7198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions sql/catalyst/src/test/scala/org/apache/spark/sql/types/decimal/DecimalSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,16 @@

package org.apache.spark.sql.types.decimal

import org.apache.spark.SparkFunSuite
import org.apache.spark.sql.types.Decimal
import scala.language.postfixOps

import org.scalacheck.Prop.forAll
import org.scalatest.PrivateMethodTester
import org.scalatest.prop.Checkers

import scala.language.postfixOps
import org.apache.spark.SparkFunSuite
import org.apache.spark.sql.types.Decimal

class DecimalSuite extends SparkFunSuite with PrivateMethodTester {
class DecimalSuite extends SparkFunSuite with PrivateMethodTester with Checkers {
test("creating decimals") {
/** Check that a Decimal has the given string representation, precision and scale */
def checkDecimal(d: Decimal, string: String, precision: Int, scale: Int): Unit = {
Expand Down Expand Up @@ -53,6 +56,12 @@ class DecimalSuite extends SparkFunSuite with PrivateMethodTester {
intercept[IllegalArgumentException](Decimal(1e17.toLong, 17, 0))
}

test("SPARK-8802: Decimal.apply(x: BigDecimal).toBigDecimal === x") {
val x = BigDecimal(BigInt("18889465931478580854784"), -2147483648)
assert(Decimal(x).toBigDecimal === x)
check(forAll((d: BigDecimal) => Decimal(d).toBigDecimal === d))
}

test("double and long values") {
/** Check that a Decimal converts to the given double and long values */
def checkValues(d: Decimal, doubleValue: Double, longValue: Long): Unit = {
Expand Down