Skip to content

Conversation

@liancheng
Copy link
Contributor

This PR forks PR #7421 authored by @piaozhexiu and adds a workaround for fixing the occasional test failures occurred in PR #7421. Please refer to these two comments for details.

(To any committers who might merge this PR: please don't forget to set the "author" field to @piaozhexiu.)

@liancheng
Copy link
Contributor Author

Gonna fire a bunch of Jenkins builds to see whether the workaround works...

@SparkQA
Copy link

SparkQA commented Jul 18, 2015

Test build #1103 has started for PR 7492 at commit 1bb9b52.

@liancheng
Copy link
Contributor Author

OK, I guess 10 builds should be enough :)

@SparkQA
Copy link

SparkQA commented Jul 18, 2015

Test build #1100 has finished for PR 7492 at commit 1bb9b52.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 18, 2015

Test build #1102 has finished for PR 7492 at commit 1bb9b52.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 18, 2015

Test build #1101 has finished for PR 7492 at commit 1bb9b52.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 18, 2015

Test build #37712 has finished for PR 7492 at commit 1bb9b52.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@liancheng liancheng force-pushed the pr-7421-workaround branch from 1bb9b52 to 53b46b6 Compare July 18, 2015 10:59
@liancheng liancheng force-pushed the pr-7421-workaround branch from 53b46b6 to 536ac41 Compare July 18, 2015 12:01
@liancheng
Copy link
Contributor Author

Um, the last wave of Jenkins builds failed due to an embarrassing typo... Updated the PR, but Jenkins is being shut down now. Will try to fire another build wave later.

@SparkQA
Copy link

SparkQA commented Jul 18, 2015

Test build #37713 has finished for PR 7492 at commit 53b46b6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 18, 2015

Test build #37714 has finished for PR 7492 at commit 536ac41.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 18, 2015

Test build #1104 has finished for PR 7492 at commit 536ac41.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 18, 2015

Test build #1108 has finished for PR 7492 at commit 536ac41.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 18, 2015

Test build #1106 has finished for PR 7492 at commit 536ac41.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 18, 2015

Test build #1105 has finished for PR 7492 at commit 536ac41.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 18, 2015

Test build #1107 has finished for PR 7492 at commit 536ac41.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@liancheng
Copy link
Contributor Author

@marmbrus @piaozhexiu The last five builds all passed. Seems that this workaround is valid. Just fired another 3 builds to double check.

@liancheng liancheng changed the title [SPARK-6910] [SQL] [DO-NOT-MERGE] Experiments a workaround of test failures in PR #7421 [SPARK-6910] [SQL] Support for pushing predicates down to metastore for partition pruning Jul 19, 2015
@piaozhexiu
Copy link

@liancheng Thank you so much for the fix! Look forward to merging the patch again.

@SparkQA
Copy link

SparkQA commented Jul 19, 2015

Test build #1110 has finished for PR 7492 at commit 536ac41.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 19, 2015

Test build #1111 has finished for PR 7492 at commit 536ac41.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 19, 2015

Test build #1112 has finished for PR 7492 at commit 536ac41.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@liancheng
Copy link
Contributor Author

@marmbrus I think it's probably OK to merge this one first. But I still haven't got any clue about the root cause mentioned in #7421 (comment) yet.

@marmbrus
Copy link
Contributor

Great, thanks guys!

@asfgit asfgit closed this in dde0e12 Jul 20, 2015
@liancheng liancheng deleted the pr-7421-workaround branch July 20, 2015 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants