[SPARK-9172][SQL] Make DecimalPrecision support for Intersect and Except #7511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #37771 has finished for PR 7511 at commit
|
Member
Author
|
A compilation error can be solved when #7510 is merged. |
Contributor
|
retest this please |
|
Test build #37772 has finished for PR 7511 at commit
|
Contributor
|
cc @cloud-fan for review |
Contributor
There was a problem hiding this comment.
nit: update the Union in comments.
Contributor
|
lgtm |
Contributor
|
Thanks - merging this in. |
|
Test build #37795 has finished for PR 7511 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/SPARK-9172
Simply make
DecimalPrecisionsupport forIntersectandExceptin addition toUnion.Besides, add unit test for
DecimalPrecisionas well.