Skip to content

Conversation

@davies
Copy link
Contributor

@davies davies commented Jul 24, 2015

Address comments for #7605

cc @rxin

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put this in decimalFunctions.scala?

@SparkQA
Copy link

SparkQA commented Jul 24, 2015

Test build #38320 has finished for PR 7634 at commit ca9c973.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class SequenceNumberRange(
    • case class SequenceNumberRanges(ranges: Array[SequenceNumberRange])
    • class KinesisBackedBlockRDDPartition(
    • class KinesisBackedBlockRDD(
    • class KinesisSequenceRangeIterator(
    • case class ChangeDecimalPrecision(child: Expression) extends UnaryExpression

@SparkQA
Copy link

SparkQA commented Jul 24, 2015

Test build #38321 has finished for PR 7634 at commit 6a91f32.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class ChangeDecimalPrecision(child: Expression) extends UnaryExpression

@SparkQA
Copy link

SparkQA commented Jul 24, 2015

Test build #38326 has finished for PR 7634 at commit 65b251c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class SequenceNumberRange(
    • case class SequenceNumberRanges(ranges: Array[SequenceNumberRange])
    • class KinesisBackedBlockRDDPartition(
    • class KinesisBackedBlockRDD(
    • class KinesisSequenceRangeIterator(
    • abstract class AlgebraicAggregate extends AggregateFunction2 with Serializable with Unevaluable
    • abstract class AggregateFunction1 extends LeafExpression with Serializable
    • case class ChangeDecimalPrecision(child: Expression) extends UnaryExpression
    • case class DecimalType(precision: Int, scale: Int) extends FractionalType
    • case class DecimalConversion(precision: Int, scale: Int) extends JDBCConversion

@davies
Copy link
Contributor Author

davies commented Jul 24, 2015

This is blocking #7642 , see https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/38337/testReport/.

so I'd like to merge this soon, once pass the tests.

@rxin
Copy link
Contributor

rxin commented Jul 24, 2015

LGTM

@SparkQA
Copy link

SparkQA commented Jul 24, 2015

Test build #38342 has finished for PR 7634 at commit b2d8b0d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class ChangeDecimalPrecision(child: Expression) extends UnaryExpression

@asfgit asfgit closed this in dfb18be Jul 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants