Skip to content

[SPARK-9385] [PYSPARK] Enable PEP8 but disable installing pylint. #7704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yhuai wants to merge 1 commit into from
Closed

[SPARK-9385] [PYSPARK] Enable PEP8 but disable installing pylint. #7704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions dev/lint-python
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,21 +58,21 @@ export "PYTHONPATH=$SPARK_ROOT_DIR/dev/pylint"
export "PYLINT_HOME=$PYTHONPATH"
export "PATH=$PYTHONPATH:$PATH"

if [ ! -d "$PYLINT_HOME" ]; then
mkdir "$PYLINT_HOME"
# Redirect the annoying pylint installation output.
easy_install -d "$PYLINT_HOME" pylint==1.4.4 &>> "$PYLINT_INSTALL_INFO"
easy_install_status="$?"

if [ "$easy_install_status" -ne 0 ]; then
echo "Unable to install pylint locally in \"$PYTHONPATH\"."
cat "$PYLINT_INSTALL_INFO"
exit "$easy_install_status"
fi

rm "$PYLINT_INSTALL_INFO"

fi
# if [ ! -d "$PYLINT_HOME" ]; then
# mkdir "$PYLINT_HOME"
# # Redirect the annoying pylint installation output.
# easy_install -d "$PYLINT_HOME" pylint==1.4.4 &>> "$PYLINT_INSTALL_INFO"
# easy_install_status="$?"
#
# if [ "$easy_install_status" -ne 0 ]; then
# echo "Unable to install pylint locally in \"$PYTHONPATH\"."
# cat "$PYLINT_INSTALL_INFO"
# exit "$easy_install_status"
# fi
#
# rm "$PYLINT_INSTALL_INFO"
#
# fi

# There is no need to write this output to a file
#+ first, but we do so so that the check status can
Expand Down
5 changes: 2 additions & 3 deletions dev/run-tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,9 +198,8 @@ def run_scala_style_checks():


def run_python_style_checks():
# set_title_and_block("Running Python style checks", "BLOCK_PYTHON_STYLE")
# run_cmd([os.path.join(SPARK_HOME, "dev", "lint-python")])
pass
set_title_and_block("Running Python style checks", "BLOCK_PYTHON_STYLE")
run_cmd([os.path.join(SPARK_HOME, "dev", "lint-python")])


def build_spark_documentation():
Expand Down