Skip to content

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Jul 29, 2015

This was previously committed but then reverted due to test failures (see #6769).

@SparkQA
Copy link

SparkQA commented Jul 29, 2015

Test build #38868 has finished for PR 7755 at commit 103beb3.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor Author

rxin commented Jul 30, 2015

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Jul 30, 2015

Test build #1232 has finished for PR 7755 at commit 103beb3.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is different from Scala output because we use different number of threads in python unit tests. See https://issues.apache.org/jira/browse/SPARK-9487.

@SparkQA
Copy link

SparkQA commented Jul 30, 2015

Test build #39094 has finished for PR 7755 at commit 542bd37.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class DateAdd(startDate: Expression, days: Expression)
    • case class DateSub(startDate: Expression, days: Expression)
    • case class UnixTimestamp(timeExp: Expression, format: Expression)
    • case class FromUnixTime(sec: Expression, format: Expression)
    • case class TimeAdd(start: Expression, interval: Expression)
    • case class TimeSub(start: Expression, interval: Expression)
    • case class AddMonths(startDate: Expression, numMonths: Expression)
    • case class MonthsBetween(date1: Expression, date2: Expression)

@SparkQA
Copy link

SparkQA commented Jul 30, 2015

Test build #39104 has finished for PR 7755 at commit fbf9044.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • case class DateAdd(startDate: Expression, days: Expression)
    • case class DateSub(startDate: Expression, days: Expression)
    • case class TimeAdd(start: Expression, interval: Expression)
    • case class TimeSub(start: Expression, interval: Expression)
    • case class AddMonths(startDate: Expression, numMonths: Expression)
    • case class MonthsBetween(date1: Expression, date2: Expression)

@mengxr
Copy link
Contributor

mengxr commented Jul 30, 2015

@rxin Should be ready now.

@rxin
Copy link
Contributor Author

rxin commented Jul 31, 2015

Merging in master.

@asfgit asfgit closed this in df32669 Jul 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants