[SPARK-9464] [WIP] [SQL] Property checks for UTF8String #7780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #38994 has finished for PR 7780 at commit
|
Contributor
Author
|
Actually, I do not have time to work on this right now, but would be glad to have someone else take over and finish this. Note that this has uncovered a few bugs already: substring() and contains() can crash with ArrayIndexOutOfBounds exceptions and it looks like the trim() functions do not handle non 0x20 whitespace characters. |
|
Test build #39012 has finished for PR 7780 at commit
|
Member
|
I'll take this over if you don't mind :) |
Contributor
Author
|
Sounds good to me; thanks @yjshen! |
asfgit
pushed a commit
that referenced
this pull request
Aug 1, 2015
This PR is based on the original work by JoshRosen in #7780, which adds ScalaCheck property-based tests for UTF8String. Author: Josh Rosen <joshrosen@databricks.com> Author: Yijie Shen <henry.yijieshen@gmail.com> Closes #7830 from yjshen/utf8-property-checks and squashes the following commits: 593da3a [Yijie Shen] resolve comments c0800e6 [Yijie Shen] Finish all todos in suite 52f51a0 [Josh Rosen] Add some more failing tests 49ed069 [Josh Rosen] Rename suite 9209c64 [Josh Rosen] UTF8String Property Checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds ScalaCheck property-based tests for UTF8String.
I'm going to push a followup commit to add additional tests; opening this early to get high-level feedback first.