Skip to content

[SPARK-9592] [SQL] Fixed First and Last aggregates to calculate on GroupedData partition instead of entire dataFrame #7928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ggupta81 wants to merge 2 commits into from
Closed

[SPARK-9592] [SQL] Fixed First and Last aggregates to calculate on GroupedData partition instead of entire dataFrame #7928

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dfd2b8
Modified First and Last aggregates to calculate on GroupedData partit…
Aug 4, 2015
fc99d87
Merge pull request #1 from apache/master
Aug 12, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,15 +647,15 @@ case class First(child: Expression) extends UnaryExpression with PartialAggregat
case class FirstFunction(expr: Expression, base: AggregateExpression1) extends AggregateFunction1 {
def this() = this(null, null) // Required for serialization.

var result: Any = null
var result: MutableLiteral = MutableLiteral(null, expr.dataType)

override def update(input: InternalRow): Unit = {
if (result == null) {
result = expr.eval(input)
if (result.value == null) {
result.value = expr.eval(input)
}
}

override def eval(input: InternalRow): Any = result
override def eval(input: InternalRow): Any = result.value
}

case class Last(child: Expression) extends UnaryExpression with PartialAggregate1 {
Expand All @@ -676,13 +676,11 @@ case class Last(child: Expression) extends UnaryExpression with PartialAggregate
case class LastFunction(expr: Expression, base: AggregateExpression1) extends AggregateFunction1 {
def this() = this(null, null) // Required for serialization.

var result: Any = null
var result: MutableLiteral = MutableLiteral(null, expr.dataType)

override def update(input: InternalRow): Unit = {
result = input
result.value = expr.eval(input)
Copy link
Contributor

@yhuai yhuai Aug 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggupta81 I see the problem. I think we only need to change this line to fix it. Basically, the input row can be a mutable row. So, we need to eagerly evaluate the expression instead of just pointing result to the input.

}

override def eval(input: InternalRow): Any = {
if (result != null) expr.eval(result.asInstanceOf[InternalRow]) else null
}
override def eval(input: InternalRow): Any = result.value
}