[SPARK-9726] [Python] PySpark DF join no longer accepts on=None #8016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cepts None as join expression
Contributor
|
Thanks - do you think you can add a test case in python/pyspark/sql/tests.py for this? |
Contributor
|
Jenkins, ok to test. |
Contributor
|
LGTM, thanks to working on this! |
Contributor
Author
|
I will add a test today or tomorrow around this. It does not look like there are any tests for joins on pyspark right now, |
|
Test build #1491 has finished for PR 8016 at commit
|
Contributor
Author
|
Still need to add tests, but it looks like this failed on the pyspark.mllib tests not anything to do with pyspark.sql |
|
Test build #1499 has finished for PR 8016 at commit
|
Contributor
|
I'm going to merge this so that we can have the fix in the 1.5 preview. Please do add the test still in a follow up pr! Thanks! |
asfgit
pushed a commit
that referenced
this pull request
Aug 12, 2015
rxin First pull request for Spark so let me know if I am missing anything The contribution is my original work and I license the work to the project under the project's open source license. Author: Brennan Ashton <bashton@brennanashton.com> Closes #8016 from btashton/patch-1. (cherry picked from commit 60103ec) Signed-off-by: Michael Armbrust <michael@databricks.com>
btashton
added a commit
to btashton/spark
that referenced
this pull request
Aug 12, 2015
rxin First pull request for Spark so let me know if I am missing anything The contribution is my original work and I license the work to the project under the project's open source license. Author: Brennan Ashton <bashton@brennanashton.com> Closes apache#8016 from btashton/patch-1.
CodingCat
pushed a commit
to CodingCat/spark
that referenced
this pull request
Aug 17, 2015
rxin First pull request for Spark so let me know if I am missing anything The contribution is my original work and I license the work to the project under the project's open source license. Author: Brennan Ashton <bashton@brennanashton.com> Closes apache#8016 from btashton/patch-1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rxin
First pull request for Spark so let me know if I am missing anything
The contribution is my original work and I license the work to the project under the project's open source license.