[SPARK-9768] [PySpark] [ML] Add Python API and user guide for ml.feature.ElementwiseProduct#8061
[SPARK-9768] [PySpark] [ML] Add Python API and user guide for ml.feature.ElementwiseProduct#8061yanboliang wants to merge 6 commits intoapache:masterfrom
Conversation
|
Jenkins, test this please. |
|
Test build #40270 has finished for PR 8061 at commit
|
docs/ml-features.md
Outdated
There was a problem hiding this comment.
style: indent to match parenthesis, as in PySpark internal code
|
Thanks for the PR! Just small comments. |
|
Test build #40628 has finished for PR 8061 at commit
|
|
Jenkins, test this please. |
|
LGTM once merge conflicts are fixed and tests pass |
|
Test build #40713 timed out for PR 8061 at commit |
|
Test build #40738 has finished for PR 8061 at commit
|
|
New though: I'm going to quickly test to see if the scalingVec can be set as a numpy or Python array. If that works, then I'll merge it. Otherwise, it'll be nice to add. |
|
Actually, thinking more about it, that should be handled in the wrapper (_transfer_params_to_java) and might take too long to do. Would you mind noting in the built-in Param doc for scalingVec that it must be an MLlib Vector type? After that, this should be ready. |
|
Test build #40947 has finished for PR 8061 at commit
|
|
@jkbradley I have updated Param doc. I opened SPARK-10009 to track the issue of supporting Param of Vector type can be set with Python array or numpy.array. I think we can resolve it in the next release cycle. |
|
test this please |
|
just testing once more, then will merge |
|
Test build #41072 has finished for PR 8061 at commit
|
|
Merging with master and branch-1.5 |
…ure.ElementwiseProduct Add Python API, user guide and example for ml.feature.ElementwiseProduct. Author: Yanbo Liang <ybliang8@gmail.com> Closes #8061 from yanboliang/SPARK-9768. (cherry picked from commit 0076e82) Signed-off-by: Joseph K. Bradley <joseph@databricks.com>
Add Python API, user guide and example for ml.feature.ElementwiseProduct.