[SPARK-9815] Rename PlatformDependent.UNSAFE -> Platform. #8094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @davies for quick review. I also plan to add some debugging functionality to help diagnose segfault. |
Contributor
|
Isn't it more clear to use UNSAFE than Platform? otherwise LGTM. |
|
Test build #40395 has finished for PR 8094 at commit
|
Contributor
Author
|
@davies I didn't think of Unsafe since it was named PlatformDependent from the beginning (which I think came from Netty). I agree that Unsafe is more clear, but also worry that unsafe is too "scary" ( probably why the new Unsafe-like feature in the JVM is being called Variable Handles http://openjdk.java.net/jeps/193 ) |
|
Test build #1442 has finished for PR 8094 at commit
|
Contributor
|
@rxin That makes sense, merging this into master and 1.5. |
asfgit
pushed a commit
that referenced
this pull request
Aug 11, 2015
PlatformDependent.UNSAFE is way too verbose. Author: Reynold Xin <rxin@databricks.com> Closes #8094 from rxin/SPARK-9815 and squashes the following commits: 229b603 [Reynold Xin] [SPARK-9815] Rename PlatformDependent.UNSAFE -> Platform. (cherry picked from commit d378396) Signed-off-by: Davies Liu <davies.liu@gmail.com>
CodingCat
pushed a commit
to CodingCat/spark
that referenced
this pull request
Aug 17, 2015
PlatformDependent.UNSAFE is way too verbose. Author: Reynold Xin <rxin@databricks.com> Closes apache#8094 from rxin/SPARK-9815 and squashes the following commits: 229b603 [Reynold Xin] [SPARK-9815] Rename PlatformDependent.UNSAFE -> Platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PlatformDependent.UNSAFE is way too verbose.