[SPARK-9426][WebUI]Job page DAG visualization is not shown #8104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
retest this please |
Contributor
|
Jenkins, retest this please. |
Contributor
|
/cc @andrewor14 for review. |
Contributor
|
cc @zsxwing |
Contributor
|
Actually, this LGTM. Thanks for fixing another blocker! I'm going to try this out locally. |
Contributor
|
retest this please |
|
Test build #40465 timed out for PR 8104 at commit |
|
Test build #40477 has finished for PR 8104 at commit
|
Contributor
|
retest this please |
2 similar comments
Contributor
|
retest this please |
Contributor
|
retest this please |
|
Test build #40515 has finished for PR 8104 at commit
|
|
Test build #1457 has finished for PR 8104 at commit
|
|
Test build #40520 timed out for PR 8104 at commit |
Member
|
LGTM |
Contributor
|
This actually passed tests. I'm merging into master 1.5. |
asfgit
pushed a commit
that referenced
this pull request
Aug 12, 2015
To reproduce the issue, go to the stage page and click DAG Visualization once, then go to the job page to show the job DAG visualization. You will only see the first stage of the job. Root cause: the java script use local storage to remember your selection. Once you click the stage DAG visualization, the local storage set `expand-dag-viz-arrow-stage` to true. When you go to the job page, the js checks `expand-dag-viz-arrow-stage` in the local storage first and will try to show stage DAG visualization on the job page. To fix this, I set an id to the DAG span to differ job page and stage page. In the js code, we check the id and local storage together to make sure we show the correct DAG visualization. Author: Carson Wang <carson.wang@intel.com> Closes #8104 from carsonwang/SPARK-9426. (cherry picked from commit bab8923) Signed-off-by: Andrew Or <andrew@databricks.com>
CodingCat
pushed a commit
to CodingCat/spark
that referenced
this pull request
Aug 17, 2015
To reproduce the issue, go to the stage page and click DAG Visualization once, then go to the job page to show the job DAG visualization. You will only see the first stage of the job. Root cause: the java script use local storage to remember your selection. Once you click the stage DAG visualization, the local storage set `expand-dag-viz-arrow-stage` to true. When you go to the job page, the js checks `expand-dag-viz-arrow-stage` in the local storage first and will try to show stage DAG visualization on the job page. To fix this, I set an id to the DAG span to differ job page and stage page. In the js code, we check the id and local storage together to make sure we show the correct DAG visualization. Author: Carson Wang <carson.wang@intel.com> Closes apache#8104 from carsonwang/SPARK-9426.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce the issue, go to the stage page and click DAG Visualization once, then go to the job page to show the job DAG visualization. You will only see the first stage of the job.
Root cause: the java script use local storage to remember your selection. Once you click the stage DAG visualization, the local storage set
expand-dag-viz-arrow-stageto true. When you go to the job page, the js checksexpand-dag-viz-arrow-stagein the local storage first and will try to show stage DAG visualization on the job page.To fix this, I set an id to the DAG span to differ job page and stage page. In the js code, we check the id and local storage together to make sure we show the correct DAG visualization.