[SPARK-9854] [SQL] RuleExecutor.timeMap should be thread-safe #8120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/cc @marmbrus |
JoshRosen
changed the title
Contributor
|
LGTM |
Contributor
Author
|
SparkQA is going to be unable to post build statuses here due to a temporary Jenkins configuration break, but we can manually check the outcome at https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/40559/. If this passes tests then I'm going to merge it immediately since I think this might cut down on a lot of the timeout-related flakiness that we've been seeing. |
Contributor
Author
|
Jenkins, retest this please. |
2 similar comments
Contributor
Author
|
Jenkins, retest this please. |
Contributor
Author
|
Jenkins, retest this please. |
|
Test build #1471 has finished for PR 8120 at commit
|
Contributor
Author
|
I'm going to merge this to master and branch-1.5. |
asfgit
pushed a commit
that referenced
this pull request
Aug 12, 2015
`RuleExecutor.timeMap` is currently a non-thread-safe mutable HashMap; this can lead to infinite loops if multiple threads are concurrently modifying the map. I believe that this is responsible for some hangs that I've observed in HiveQuerySuite. This patch addresses this by using a Guava `AtomicLongMap`. Author: Josh Rosen <joshrosen@databricks.com> Closes #8120 from JoshRosen/rule-executor-time-map-fix. (cherry picked from commit b1581ac) Signed-off-by: Josh Rosen <joshrosen@databricks.com>
|
Test build #1472 has finished for PR 8120 at commit
|
CodingCat
pushed a commit
to CodingCat/spark
that referenced
this pull request
Aug 17, 2015
`RuleExecutor.timeMap` is currently a non-thread-safe mutable HashMap; this can lead to infinite loops if multiple threads are concurrently modifying the map. I believe that this is responsible for some hangs that I've observed in HiveQuerySuite. This patch addresses this by using a Guava `AtomicLongMap`. Author: Josh Rosen <joshrosen@databricks.com> Closes apache#8120 from JoshRosen/rule-executor-time-map-fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RuleExecutor.timeMapis currently a non-thread-safe mutable HashMap; this can lead to infinite loops if multiple threads are concurrently modifying the map. I believe that this is responsible for some hangs that I've observed in HiveQuerySuite.This patch addresses this by using a Guava
AtomicLongMap.