[SPARK-9757] [SQL] Fixes persistence of Parquet relation with decimal column #8130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liancheng
force-pushed
the
spark-9757/old-hive-parquet-decimal
branch
from
7a9c045 to
194d7db
Compare
|
Test build #40641 has finished for PR 8130 at commit
|
Contributor
There was a problem hiding this comment.
Should we use our own hive client's notion of version instead of a regex here?
|
Test build #40650 has finished for PR 8130 at commit
|
|
Test build #1501 has finished for PR 8130 at commit
|
|
Test build #40660 has finished for PR 8130 at commit
|
liancheng
force-pushed
the
spark-9757/old-hive-parquet-decimal
branch
from
d42a0ef to
f4e4c2c
Compare
|
Test build #1507 has finished for PR 8130 at commit
|
Contributor
|
Test build 1507 is not for the latest commit. I manually triggered 1525. |
|
Test build #1525 has finished for PR 8130 at commit
|
Contributor
Author
|
(Please ignore this comment, meant to post it on #8158...) |
Contributor
Author
asfgit
pushed a commit
that referenced
this pull request
Aug 13, 2015
… column PR #7967 enables us to save data source relations to metastore in Hive compatible format when possible. But it fails to persist Parquet relations with decimal column(s) to Hive metastore of versions lower than 1.2.0. This is because `ParquetHiveSerDe` in Hive versions prior to 1.2.0 doesn't support decimal. This PR checks for this case and falls back to Spark SQL specific metastore table format. Author: Yin Huai <yhuai@databricks.com> Author: Cheng Lian <lian@databricks.com> Closes #8130 from liancheng/spark-9757/old-hive-parquet-decimal. (cherry picked from commit 6993031) Signed-off-by: Cheng Lian <lian@databricks.com>
CodingCat
pushed a commit
to CodingCat/spark
that referenced
this pull request
Aug 17, 2015
… column PR apache#7967 enables us to save data source relations to metastore in Hive compatible format when possible. But it fails to persist Parquet relations with decimal column(s) to Hive metastore of versions lower than 1.2.0. This is because `ParquetHiveSerDe` in Hive versions prior to 1.2.0 doesn't support decimal. This PR checks for this case and falls back to Spark SQL specific metastore table format. Author: Yin Huai <yhuai@databricks.com> Author: Cheng Lian <lian@databricks.com> Closes apache#8130 from liancheng/spark-9757/old-hive-parquet-decimal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #7967 enables us to save data source relations to metastore in Hive compatible format when possible. But it fails to persist Parquet relations with decimal column(s) to Hive metastore of versions lower than 1.2.0. This is because
ParquetHiveSerDein Hive versions prior to 1.2.0 doesn't support decimal. This PR checks for this case and falls back to Spark SQL specific metastore table format.