Skip to content

Conversation

@holdenk
Copy link
Contributor

@holdenk holdenk commented Aug 12, 2015

As per the TODO move weightCol to Shared Params.

@mengxr
Copy link
Contributor

mengxr commented Aug 12, 2015

LGTM pending Jenkins.

@SparkQA
Copy link

SparkQA commented Aug 12, 2015

Test build #40675 has finished for PR 8144 at commit 3d50107.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Aug 12, 2015
As per the TODO move weightCol to Shared Params.

Author: Holden Karau <holden@pigscanfly.ca>

Closes #8144 from holdenk/SPARK-9909-move-weightCol-toSharedParams.

(cherry picked from commit 6e409bc)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@mengxr
Copy link
Contributor

mengxr commented Aug 12, 2015

Merged into master and branch-1.5. Thanks!

@asfgit asfgit closed this in 6e409bc Aug 12, 2015
CodingCat pushed a commit to CodingCat/spark that referenced this pull request Aug 17, 2015
As per the TODO move weightCol to Shared Params.

Author: Holden Karau <holden@pigscanfly.ca>

Closes apache#8144 from holdenk/SPARK-9909-move-weightCol-toSharedParams.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants