-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK 9902] [MLlib] Add Java and Python examples to user guide for 1-sample KS test #8154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
add to whitelist |
|
ok to test |
|
Test build #40850 has finished for PR 8154 at commit
|
docs/mllib-statistics.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data = sc.parallelize([1.0, 2.0, ...]) should be sufficient.
|
@josepablocam For Java example, you can check the code here: https://github.com/apache/spark/blob/master/mllib/src/test/java/org/apache/spark/mllib/stat/JavaStatisticsSuite.java#L63. |
1bad75f to
b914058
Compare
|
@mengxr added Java example now, thanks! |
|
Test build #40928 has finished for PR 8154 at commit
|
docs/mllib-statistics.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: We can use Arrays.asList to replace Lists.newArrayList. The former is from Java core, which doesn't require additional dependencies. Then we can replace import com.google.common.collect.Lists; by import java.util.Arrays;. Btw, please insert an empty line between Java imports and Spark imports.
|
LGTM except minor inline comments. |
… fixed python link. Made 1 additional fix from a typo
|
@mengxr thanks for the feedback. Fixed |
|
LGTM. Merged into master and branch-1.5. Thanks! (Skipped Jenkins because this is doc-only.) |
|
Test build #41086 has finished for PR 8154 at commit
|
added doc examples for python.