Skip to content

[SPARK-9900][MLlib] User guide for Association Rules #8207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
feynmanliang wants to merge 3 commits into from
Closed

[SPARK-9900][MLlib] User guide for Association Rules #8207

feynmanliang wants to merge 3 commits into from

Conversation

@feynmanliang
Copy link
Contributor

@feynmanliang feynmanliang commented Aug 14, 2015

Updates FPM user guide to include Association Rules.

@SparkQA
Copy link

SparkQA commented Aug 14, 2015

Test build #40893 has finished for PR 8207 at commit c4db4db.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

mengxr
mengxr reviewed Aug 14, 2015
View reviewed changes
docs/mllib-frequent-pattern-mining.md Outdated
Copy link
Contributor

@mengxr mengxr Aug 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the default behavior of java.util.List.toString. System.out.println(rule.javaAntecedent() + " => " + rule.javaConsequent() + ", " + rule.confidence()) should work. Then we can remove Guava imports.

Copy link
Contributor Author

@feynmanliang feynmanliang Aug 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@mengxr
Copy link
Contributor

mengxr commented Aug 14, 2015

@feynmanliang Shall we add one line to FPGrowth's example code to show how to generate rules directly from FPGrowthModel?

@feynmanliang
Copy link
Contributor Author

feynmanliang commented Aug 14, 2015

@mengxr I considered that but felt that it was important to document our rule generation only supports single consequent rules. If you think appending that to the FPGrowth docs is acceptable, I'm happy to make the change.

@mengxr
Copy link
Contributor

mengxr commented Aug 14, 2015

We can add one line to FPGrowth example code and point users to AssociationRules example. I believe that most users would generate association rules directly from FPGrowthModel.

@feynmanliang
Copy link
Contributor Author

feynmanliang commented Aug 17, 2015

@mengxr rebased to include #8206 and revised as suggested

@mengxr
Copy link
Contributor

mengxr commented Aug 17, 2015

@feynmanliang There are some merge conflicts wtih #8255. Could you update this PR and also add a link to association rules in ml-guide.md? Thanks!

@SparkQA
Copy link

SparkQA commented Aug 18, 2015

Test build #41067 has finished for PR 8207 at commit 6b055cf.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor

mengxr commented Aug 18, 2015

@feynmanliang This may require another rebase ...

Feynman Liang added 3 commits August 18, 2015 10:19
Working scala code example, fix nonsense test
65ca8d6
Improves association rule and FPGrowth documentation
b3ffb18 
 * Removes Guava dependence from all Java examples in FPM user guide
 * Moves Association Rule documentation under codetabs
 * Adds a concrete `transactions` dataset for FPGrowth examples
 * Extends FPGrowth code example to show direct rule generation from FPGrowthModel
Add association rules to mllib-guide
b038826
@feynmanliang
Copy link
Contributor Author

feynmanliang commented Aug 18, 2015

@mengxr Rebased (again...) :trollface:

@SparkQA
Copy link

SparkQA commented Aug 18, 2015

Test build #41147 has finished for PR 8207 at commit b038826.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mengxr
Copy link
Contributor

mengxr commented Aug 18, 2015

LGTM. Merged into master and branch-1.5. Thanks!

@asfgit asfgit closed this in f5ea391 Aug 18, 2015
asfgit pushed a commit that referenced this pull request Aug 18, 2015
@mengxr
[SPARK-9900] [MLLIB] User guide for Association Rules
7ff0e5d 
Updates FPM user guide to include Association Rules.

Author: Feynman Liang <fliang@databricks.com>

Closes #8207 from feynmanliang/SPARK-9900-arules.

(cherry picked from commit f5ea391)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@feynmanliang feynmanliang deleted the SPARK-9900-arules branch August 18, 2015 20:45
@mengxr mengxr mentioned this pull request Aug 19, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@feynmanliang @SparkQA @mengxr