[MINOR] fix the comments in IndexShuffleBlockResolver #8238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM |
|
Test build #41021 timed out for PR 8238 at commit |
|
Test build #41040 has finished for PR 8238 at commit
|
Member
|
retest this please. |
|
Test build #41090 has finished for PR 8238 at commit
|
Member
|
The test failures must be spurious. The fix must be correct since there is no method called |
asfgit
pushed a commit
that referenced
this pull request
Aug 18, 2015
it might be a typo introduced at the first moment or some leftover after some renaming...... the name of the method accessing the index file is called `getBlockData` now (not `getBlockLocation` as indicated in the comments) Author: CodingCat <zhunansjtu@gmail.com> Closes #8238 from CodingCat/minor_1. (cherry picked from commit c34e9ff) Signed-off-by: Sean Owen <sowen@cloudera.com>
Contributor
Author
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it might be a typo introduced at the first moment or some leftover after some renaming......
the name of the method accessing the index file is called
getBlockDatanow (notgetBlockLocationas indicated in the comments)