Skip to content

Conversation

@avulanov
Copy link
Contributor

Added user guide for multilayer perceptron classifier:

  • Simplified description of the multilayer perceptron classifier
  • Example code for Scala and Java

@SparkQA
Copy link

SparkQA commented Aug 18, 2015

Test build #41084 has finished for PR 8262 at commit 96683ce.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

docs/ml-ann.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use MulticlassClassificationEvaluator instead.

@avulanov
Copy link
Contributor Author

@mengxr Thank you for your comments! I've addressed everything except the full chop of setters for the Java trainer. It complains on java: incompatible types: org.apache.spark.ml.classification.MultilayerPerceptronParams cannot be converted to org.apache.spark.ml.classification.MultilayerPerceptronClassifier. I did it in two stages. Also I've left Java imports.

@avulanov
Copy link
Contributor Author

The test fail seems unrelated to my commit.

@mengxr
Copy link
Contributor

mengxr commented Aug 20, 2015

Ah, that is a bug I overlooked in review. We must define setters in the final class so the return type in Java is the self type. I will send a PR for it and ping you back.

docs/ml-ann.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use 2-space indentation (and please fix indentation in other places)

@mengxr
Copy link
Contributor

mengxr commented Aug 20, 2015

LGTM except some indentation issues.

@avulanov avulanov force-pushed the SPARK-9846-mlpc-docs branch from 95106f5 to 07ada2b Compare August 21, 2015 00:37
@avulanov
Copy link
Contributor Author

@mengxr Thank you. Fixed indentation and removed trainer. Java example works now.

@SparkQA
Copy link

SparkQA commented Aug 21, 2015

Test build #41335 has finished for PR 8262 at commit 07ada2b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Aug 21, 2015
Added user guide for multilayer perceptron classifier:
  - Simplified description of the multilayer perceptron classifier
  - Example code for Scala and Java

Author: Alexander Ulanov <nashb@yandex.ru>

Closes #8262 from avulanov/SPARK-9846-mlpc-docs.

(cherry picked from commit dcfe0c5)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@mengxr
Copy link
Contributor

mengxr commented Aug 21, 2015

Merged into master and branch-1.5. Thanks!

@asfgit asfgit closed this in dcfe0c5 Aug 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants