Skip to content

[SPARK-10040][SQL] Use batch insert for JDBC writing #8273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
viirya wants to merge 4 commits into from
Closed

[SPARK-10040][SQL] Use batch insert for JDBC writing #8273

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1062cda
Use batch insert for JDBC.
viirya Aug 18, 2015
1a474e9
Increase batch size.
viirya Aug 19, 2015
a63a1b3
Add a configuration for batch size.
viirya Aug 19, 2015
f8b9566
Use "batchsize".
viirya Aug 21, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,15 @@ object JdbcUtils extends Logging {
table: String,
iterator: Iterator[Row],
rddSchema: StructType,
nullTypes: Array[Int]): Iterator[Byte] = {
nullTypes: Array[Int],
batchSize: Int): Iterator[Byte] = {
val conn = getConnection()
var committed = false
try {
conn.setAutoCommit(false) // Everything in the same db transaction.
val stmt = insertStatement(conn, table, rddSchema)
try {
var rowCount = 0
while (iterator.hasNext) {
val row = iterator.next()
val numFields = rddSchema.fields.length
Expand Down Expand Up @@ -122,7 +124,15 @@ object JdbcUtils extends Logging {
}
i = i + 1
}
stmt.executeUpdate()
stmt.addBatch()
rowCount += 1
if (rowCount % batchSize == 0) {
stmt.executeBatch()
rowCount = 0
}
}
if (rowCount > 0) {
stmt.executeBatch()
}
} finally {
stmt.close()
Expand Down Expand Up @@ -211,8 +221,9 @@ object JdbcUtils extends Logging {
val rddSchema = df.schema
val driver: String = DriverRegistry.getDriverClassName(url)
val getConnection: () => Connection = JDBCRDD.getConnector(driver, url, properties)
val batchSize = properties.getProperty("batchsize", "1000").toInt
df.foreachPartition { iterator =>
savePartition(getConnection, table, iterator, rddSchema, nullTypes)
savePartition(getConnection, table, iterator, rddSchema, nullTypes, batchSize)
}
}

Expand Down