-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-9401][SQL]Fully implement code generation for ConcatWs #8353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #41361 has finished for PR 8353 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: j is only available in loop scope, so we don't need to create an unique name for it.
|
LGTM, just one minor comment. |
|
@yjshen Another thing we could do is that we could count the number of strings, then create the array directly, do need to have a ArrayList. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be the number of vargs that is UTF8String (${children.count(_ == StringType) - 1} ).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use this as the total num of strings, stringType + arrayType's element num.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I means we can get rid of some many num ++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, yes, I get this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davies , more comments on this PR?
|
Test build #41403 has finished for PR 8353 at commit
|
|
Test build #41404 has finished for PR 8353 at commit
|
|
LGTM, merging this to master, thanks! |
This PR adds full codegen support for ConcatWs, is a substitute of #7782
JIRA: https://issues.apache.org/jira/browse/SPARK-9401
cc @davies