Skip to content

Conversation

@yjshen
Copy link
Member

@yjshen yjshen commented Aug 21, 2015

This PR adds full codegen support for ConcatWs, is a substitute of #7782

JIRA: https://issues.apache.org/jira/browse/SPARK-9401

cc @davies

@SparkQA
Copy link

SparkQA commented Aug 21, 2015

Test build #41361 has finished for PR 8353 at commit affd497.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: j is only available in loop scope, so we don't need to create an unique name for it.

@davies
Copy link
Contributor

davies commented Aug 21, 2015

LGTM, just one minor comment.

@davies
Copy link
Contributor

davies commented Aug 21, 2015

@yjshen Another thing we could do is that we could count the number of strings, then create the array directly, do need to have a ArrayList.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be the number of vargs that is UTF8String (${children.count(_ == StringType) - 1} ).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use this as the total num of strings, stringType + arrayType's element num.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I means we can get rid of some many num ++

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, yes, I get this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davies , more comments on this PR?

@SparkQA
Copy link

SparkQA commented Aug 22, 2015

Test build #41403 has finished for PR 8353 at commit 84c1dfb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 22, 2015

Test build #41404 has finished for PR 8353 at commit eb29b30.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@davies
Copy link
Contributor

davies commented Aug 22, 2015

LGTM, merging this to master, thanks!

@asfgit asfgit closed this in 90cb9f0 Aug 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants