Skip to content

Conversation

@jkbradley
Copy link
Member

User guide for spark.ml GBTs and Random Forests.
The examples are copied from the decision tree guide and modified to run.

I caught some issues I had somehow missed in the tree guide as well.

I have run all examples, including Java ones. (Of course, I thought I had previously as well...)

CC: @mengxr @manishamde @yanboliang

@jkbradley
Copy link
Member Author

Note: This is blocked by [https://github.com//pull/8367]

@SparkQA
Copy link

SparkQA commented Aug 21, 2015

Test build #41393 has finished for PR 8369 at commit e054358.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • * a bit more functionality for random forests: estimates of feature importance, as well as the predicted probability of each class (a.k.a. class conditional probabilities) for classification.
    • [OneVsRest](http://en.wikipedia.org/wiki/Multiclass_classification#One-vs.-rest) is an example of a machine learning reduction for performing multiclass classification given a base classifier that can perform binary classification efficiently. It is also known as "One-vs-All."

@jkbradley
Copy link
Member Author

Rebased to include GBT fix in master.

@SparkQA
Copy link

SparkQA commented Aug 22, 2015

Test build #41395 has finished for PR 8369 at commit 42f4f2a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • * a bit more functionality for random forests: estimates of feature importance, as well as the predicted probability of each class (a.k.a. class conditional probabilities) for classification.
    • [OneVsRest](http://en.wikipedia.org/wiki/Multiclass_classification#One-vs.-rest) is an example of a machine learning reduction for performing multiclass classification given a base classifier that can perform binary classification efficiently. It is also known as "One-vs-All."
    • public class JavaVectorSlicerSuite

@SparkQA
Copy link

SparkQA commented Aug 24, 2015

Test build #41433 has finished for PR 8369 at commit 5598f46.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yanboliang
Copy link
Contributor

Looks good!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space after []

@mengxr
Copy link
Contributor

mengxr commented Aug 24, 2015

LGTM except some minor comments.

@jkbradley
Copy link
Member Author

OK I think that does it. Thanks for reviewing!

@SparkQA
Copy link

SparkQA commented Aug 24, 2015

Test build #41476 has finished for PR 8369 at commit e1c6e18.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Aug 24, 2015
User guide for spark.ml GBTs and Random Forests.
The examples are copied from the decision tree guide and modified to run.

I caught some issues I had somehow missed in the tree guide as well.

I have run all examples, including Java ones.  (Of course, I thought I had previously as well...)

CC: mengxr manishamde yanboliang

Author: Joseph K. Bradley <joseph@databricks.com>

Closes #8369 from jkbradley/ml-ensemble-docs.

(cherry picked from commit 13db11c)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@mengxr
Copy link
Contributor

mengxr commented Aug 24, 2015

Merged into master and branch-1.5. Thanks!

@asfgit asfgit closed this in 13db11c Aug 24, 2015
@jkbradley jkbradley deleted the ml-ensemble-docs branch August 24, 2015 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants