Skip to content

Conversation

@feynmanliang
Copy link
Contributor

CC @jkbradley @mengxr

@feynmanliang feynmanliang changed the title [SPARK-9905] Adds LinearRegressionSummary user guide [SPARK-9905][ML][Doc] Adds LinearRegressionSummary user guide Aug 28, 2015
@SparkQA
Copy link

SparkQA commented Aug 28, 2015

Test build #41713 has finished for PR 8491 at commit 4e5aaeb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • public class LinearRegressionWithElasticNetExample

asfgit pushed a commit that referenced this pull request Aug 28, 2015
* Adds user guide for `LinearRegressionSummary`
* Fixes unresolved issues in  #8197

CC jkbradley mengxr

Author: Feynman Liang <fliang@databricks.com>

Closes #8491 from feynmanliang/SPARK-9905.

(cherry picked from commit af0e124)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@mengxr
Copy link
Contributor

mengxr commented Aug 28, 2015

LGTM. Merged into master and branch-1.5. Thanks!

Not related to this PR, the major issue with this page is missing documentation about input columns and output columns of linear models, and there are no example code to demo them.

Another question is whether we should keep the main class in Java example code. I think most of our Java example code do not have it, and assume jsc and sqlContext are provided. This could simplify the example code a little bit.

@asfgit asfgit closed this in af0e124 Aug 28, 2015
@feynmanliang
Copy link
Contributor Author

@mengxr WRT 1, completely agree and created SPARK-10333

WRT 2, I agree we should be consistent throughout the code examples. However, I've felt awkward writing the Java examples at times because unlike Scala and Python there is no REPL which injects the context variables in and allows us to just copy/paste the example in to run. Keeping the main class makes it easy to paste the file, compile and JAR it, and use spark-submit to run the code example.

@feynmanliang feynmanliang deleted the SPARK-9905 branch August 28, 2015 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants