Skip to content

[SPARK-10431][ Spark Core ] Fix intermittent test failure. Wait for event queue to be clear #8582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
robbinspg wants to merge 1 commit into from
Closed

[SPARK-10431][ Spark Core ] Fix intermittent test failure. Wait for event queue to be clear #8582

robbinspg wants to merge 1 commit into from

Conversation

@robbinspg
Copy link
Member

@robbinspg robbinspg commented Sep 3, 2015

No description provided.

@srowen
Copy link
Member

srowen commented Sep 3, 2015

Although I'm not so familiar with this, seems reasonable to me.

@SparkQA
Copy link

SparkQA commented Sep 3, 2015

Test build #1717 has finished for PR 8582 at commit 3f8f21d.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@robbinspg
Copy link
Member Author

robbinspg commented Sep 3, 2015

I see the test failure is https://issues.apache.org/jira/browse/SPARK-9869 which I'm sure is not related to this pull request.

Ironically, looking at SPARK-9869 it looks like it could be a very similar issue to this fix, ie waiting for the listenerBus is empty before the asserts!

@srowen
Copy link
Member

srowen commented Sep 3, 2015

Agree, let's see what happens on a second run here.

@SparkQA
Copy link

SparkQA commented Sep 3, 2015

Test build #1718 has finished for PR 8582 at commit 3f8f21d.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor

andrewor14 commented Sep 3, 2015

retest this please

@andrewor14
Copy link
Contributor

andrewor14 commented Sep 3, 2015

Yup, LGTM. In the specific test you reported in the JIRA we ran a job before calling runAndReturnMetrics, so it makes sense to ensure the queue is empty before running the thing we actually care about.

@SparkQA
Copy link

SparkQA commented Sep 3, 2015

Test build #41978 has finished for PR 8582 at commit 3f8f21d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in d911c68 Sep 3, 2015
asfgit pushed a commit that referenced this pull request Sep 3, 2015
[SPARK-10431] [CORE] Fix intermittent test failure. Wait for event qu…
4d63335 
…eue to be clear

Author: robbins <robbins@uk.ibm.com>

Closes #8582 from robbinspg/InputOutputMetricsSuite.
@andrewor14
Copy link
Contributor

andrewor14 commented Sep 3, 2015

Merged into master 1.5

@robbinspg robbinspg deleted the InputOutputMetricsSuite branch May 5, 2016 07:46
ashangit pushed a commit to ashangit/spark that referenced this pull request Oct 19, 2016
[SPARK-10431] [CORE] Fix intermittent test failure. Wait for event qu…
8603ce9 
…eue to be clear

Author: robbins <robbins@uk.ibm.com>

Closes apache#8582 from robbinspg/InputOutputMetricsSuite.

(cherry picked from commit 4d63335)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@robbinspg @srowen @SparkQA @andrewor14