Skip to content

[SPARK-1926] [SQL] Nullability of Max/Min/First should be true. #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ueshin wants to merge 1 commit into from
Closed

[SPARK-1926] [SQL] Nullability of Max/Min/First should be true. #881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ abstract class AggregateFunction

case class Min(child: Expression) extends PartialAggregate with trees.UnaryNode[Expression] {
override def references = child.references
override def nullable = child.nullable
override def nullable = true
override def dataType = child.dataType
override def toString = s"MIN($child)"

Expand Down Expand Up @@ -120,7 +120,7 @@ case class MinFunction(expr: Expression, base: AggregateExpression) extends Aggr

case class Max(child: Expression) extends PartialAggregate with trees.UnaryNode[Expression] {
override def references = child.references
override def nullable = child.nullable
override def nullable = true
override def dataType = child.dataType
override def toString = s"MAX($child)"

Expand Down Expand Up @@ -257,7 +257,7 @@ case class SumDistinct(child: Expression)

case class First(child: Expression) extends PartialAggregate with trees.UnaryNode[Expression] {
override def references = child.references
override def nullable = child.nullable
override def nullable = true
override def dataType = child.dataType
override def toString = s"FIRST($child)"

Expand Down