-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-10775][UI]add search keywords in history page ui #8885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #42908 has finished for PR 8885 at commit
|
|
@lianhuiwang would you mind rebasing to master? |
|
I'll inspect the details but I'm not sure whether it's useful to enable to search by app id. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's difficult for users to know what is the targets searched by keywords. How about set initial message "Input App Names" or like that to the text field and remove "Search" label.
It's just one idea. Someone might have better idea.
|
@andrewor14 Yes, I will rebase to master. |
Conflicts: core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala
This reverts commit bff49b8.
|
@andrewor14 Now i think that's OK. Can you look at it? Thanks. |
|
test this please |
|
Test build #47825 has finished for PR 8885 at commit
|
|
Test build #47828 has finished for PR 8885 at commit
|
|
@sarutak Thanks. I have addressed your comments.Now UI is as following: |
|
Test build #47880 has finished for PR 8885 at commit
|
|
test this please. |
|
Test build #47897 has finished for PR 8885 at commit
|
|
@andrewor14 @sarutak Now all tests have passed. |
|
so in https://issues.apache.org/jira/browse/SPARK-10873 we are looking at changing to use the jquery datatables. This would give us a bunch of things including a search box for free. We are close to having a prototype of the history server working. |
|
@lianhuiwang #10648 has already merged and I think it includes features proposed in this PR. So, do you mind closing this PR? |
|
@sarutak Yes, I will close this PR. Thanks. |

add search button in history page ui that we can search some applications of keywords,example: date or time.The ui is as the following photo:
