Skip to content

Conversation

@lianhuiwang
Copy link
Contributor

add search button in history page ui that we can search some applications of keywords,example: date or time.The ui is as the following photo:
historyserver-ui-search

@SparkQA
Copy link

SparkQA commented Sep 23, 2015

Test build #42908 has finished for PR 8885 at commit 5f5be5b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor

@lianhuiwang would you mind rebasing to master?

@andrewor14
Copy link
Contributor

@sarutak @vanzin

@sarutak
Copy link
Member

sarutak commented Dec 15, 2015

I'll inspect the details but I'm not sure whether it's useful to enable to search by app id.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's difficult for users to know what is the targets searched by keywords. How about set initial message "Input App Names" or like that to the text field and remove "Search" label.
It's just one idea. Someone might have better idea.

@lianhuiwang
Copy link
Contributor Author

@andrewor14 Yes, I will rebase to master.

@lianhuiwang
Copy link
Contributor Author

@andrewor14 Now i think that's OK. Can you look at it? Thanks.

@lianhuiwang
Copy link
Contributor Author

test this please

@SparkQA
Copy link

SparkQA commented Dec 16, 2015

Test build #47825 has finished for PR 8885 at commit 16965b6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 16, 2015

Test build #47828 has finished for PR 8885 at commit 16965b6.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@lianhuiwang
Copy link
Contributor Author

@sarutak Thanks. I have addressed your comments.Now UI is as following:
history-ui

@SparkQA
Copy link

SparkQA commented Dec 17, 2015

Test build #47880 has finished for PR 8885 at commit a3f6885.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaBisectingKMeansExample\n * class CrossValidator(Estimator, HasSeed):\n

@lianhuiwang
Copy link
Contributor Author

test this please.

@SparkQA
Copy link

SparkQA commented Dec 17, 2015

Test build #47897 has finished for PR 8885 at commit a3f6885.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@lianhuiwang
Copy link
Contributor Author

@andrewor14 @sarutak Now all tests have passed.

@tgravescs
Copy link
Contributor

so in https://issues.apache.org/jira/browse/SPARK-10873 we are looking at changing to use the jquery datatables. This would give us a bunch of things including a search box for free. We are close to having a prototype of the history server working.

@sarutak
Copy link
Member

sarutak commented Mar 11, 2016

@lianhuiwang #10648 has already merged and I think it includes features proposed in this PR. So, do you mind closing this PR?

@lianhuiwang
Copy link
Contributor Author

@sarutak Yes, I will close this PR. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants