[SPARK-11270] [STREAMING] Add improved equality testing for TopicAndPartition from the Kafka Streaming API

[ontarionick]

@jerryshao @tdas

I know this is kind of minor, and I know you all are busy, but this brings this class in line with the OffsetRange class, and makes tests a little more concise.

Instead of doing something like:

assert topic_and_partition_instance._topic == "foo"
assert topic_and_partition_instance._partition == 0

You can do something like:

assert topic_and_partition_instance == TopicAndPartition("foo", 0)

Before:

>>> from pyspark.streaming.kafka import TopicAndPartition
>>> TopicAndPartition("foo", 0) == TopicAndPartition("foo", 0)
False

After:

>>> from pyspark.streaming.kafka import TopicAndPartition
>>> TopicAndPartition("foo", 0) == TopicAndPartition("foo", 0)
True

I couldn't find any tests - am I missing something?

[jerryshao]

LGTM, the test is in pyspark/streaming/tests.py, you can refer to it.

[ontarionick]

Tests added!

[tdas]

ok to test

[tdas]

LGTM. Will merge when tests pass.

[SparkQA]

Test build #44391 has finished for PR 9236 at commit 669a7ba.

• This patch fails Python style tests.
• This patch merges cleanly.
• This patch adds no public classes.

[tdas]

Could you update the code to fix the python style issues?

On Mon, Oct 26, 2015 at 7:32 PM, UCB AMPLab notifications@github.com
wrote:

Merged build finished. Test FAILed.

—
Reply to this email directly or view it on GitHub
#9236 (comment).

[ontarionick]

@tdas fixed!

[SparkQA]

Test build #44393 has finished for PR 9236 at commit 8a3e5a3.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.