-
Notifications
You must be signed in to change notification settings - Fork 29k
Fix typos #9250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos #9250
Conversation
|
To lower the overhead, maybe you can take a pass over all of the project to detect typos? a spell-checker will turn up way too many false positives, but half an hour skimming them might flag a few more fixes. Inevitably small fixes will just turn up in the course of other work, but whatever can be done to batch together tiny but thematically similar changes would be appreciated. |
|
Test build #1945 has finished for PR 9250 at commit
|
|
Disregard the failure, it's unrelated |
|
Ok, deal. I can run a spell-checker and see what I can fix within a half-an-hour timeframe. Should I go and create a JIRA task for it? Any particular module/package to look at during the timeframe? Thanks @srowen for the help! |
|
If it's a handful of typos I wouldn't bother with a JIRA. I think the operating theory is JIRA = what and PR = how, and if those are virtually the same there's no point in duplicating. I'd focus on docs I suppose as it is much more to be read. In fact I don't know if you could reasonably search scala source for typos because of all the false positives, but searching generated scaladoc might be reasonable. Still, sounds possibly too noisy to search. |
|
+1 If you are doing a lot of these, it'd be great to batch them. Don't be mistaken - the effort is hugely appreciated! |
|
Thanks @rxin @srowen for support! It took me 30 minutes to find and use I'd rather be spending my time on fixing the typos in the docs as I know where few typos lurk. Thanks again! |
|
Yeah that's fine, I think Scala files may be too much to bear. I just use the spell-checker in the IDE as I find it a little easier to manage. Docs are indeed higher value and easier to manage. |
|
@jaceklaskowski is this ready to be merged or are you waiting to submit more? |
|
I need few more hours. I'll ping you. Thanks. |
|
It's fine if this is what you've found. I can merge |
7d1b20d to
693877e
Compare
|
All for now. Merge at will. Thanks. |
|
Test build #1953 has finished for PR 9250 at commit
|
|
Merged to master/1.5 |
Two typos squashed. BTW Let me know how to proceed with other typos if I ran across any. I don't feel well to leave them aside as much as sending pull requests with such tiny changes. Guide me. Author: Jacek Laskowski <jacek.laskowski@deepsense.io> Closes #9250 from jaceklaskowski/typos-hunting. (cherry picked from commit 146da0d) Signed-off-by: Sean Owen <sowen@cloudera.com>
Two typos squashed.
BTW Let me know how to proceed with other typos if I ran across any. I don't feel well to leave them aside as much as sending pull requests with such tiny changes. Guide me.