Skip to content

Conversation

@jaceklaskowski
Copy link
Contributor

Two typos squashed.

BTW Let me know how to proceed with other typos if I ran across any. I don't feel well to leave them aside as much as sending pull requests with such tiny changes. Guide me.

@srowen
Copy link
Member

srowen commented Oct 23, 2015

To lower the overhead, maybe you can take a pass over all of the project to detect typos? a spell-checker will turn up way too many false positives, but half an hour skimming them might flag a few more fixes. Inevitably small fixes will just turn up in the course of other work, but whatever can be done to batch together tiny but thematically similar changes would be appreciated.

@SparkQA
Copy link

SparkQA commented Oct 23, 2015

Test build #1945 has finished for PR 9250 at commit 7d1b20d.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Oct 23, 2015

Disregard the failure, it's unrelated

@jaceklaskowski
Copy link
Contributor Author

Ok, deal. I can run a spell-checker and see what I can fix within a half-an-hour timeframe. Should I go and create a JIRA task for it? Any particular module/package to look at during the timeframe?

Thanks @srowen for the help!

@srowen
Copy link
Member

srowen commented Oct 23, 2015

If it's a handful of typos I wouldn't bother with a JIRA. I think the operating theory is JIRA = what and PR = how, and if those are virtually the same there's no point in duplicating.

I'd focus on docs I suppose as it is much more to be read. In fact I don't know if you could reasonably search scala source for typos because of all the false positives, but searching generated scaladoc might be reasonable. Still, sounds possibly too noisy to search.

@rxin
Copy link
Contributor

rxin commented Oct 23, 2015

+1

If you are doing a lot of these, it'd be great to batch them. Don't be mistaken - the effort is hugely appreciated!

@jaceklaskowski
Copy link
Contributor Author

Thanks @rxin @srowen for support! It took me 30 minutes to find and use aspell on a single Scala package and it drove me crazy with tons of false positives - every Scala class name was wrong :(

I'd rather be spending my time on fixing the typos in the docs as I know where few typos lurk.

Thanks again!

@srowen
Copy link
Member

srowen commented Oct 23, 2015

Yeah that's fine, I think Scala files may be too much to bear. I just use the spell-checker in the IDE as I find it a little easier to manage. Docs are indeed higher value and easier to manage.

@rxin
Copy link
Contributor

rxin commented Oct 23, 2015

@jaceklaskowski is this ready to be merged or are you waiting to submit more?

@jaceklaskowski
Copy link
Contributor Author

I need few more hours. I'll ping you. Thanks.

@srowen
Copy link
Member

srowen commented Oct 24, 2015

It's fine if this is what you've found. I can merge

@jaceklaskowski
Copy link
Contributor Author

All for now. Merge at will. Thanks.

@SparkQA
Copy link

SparkQA commented Oct 25, 2015

Test build #1953 has finished for PR 9250 at commit 693877e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Oct 25, 2015

Merged to master/1.5

asfgit pushed a commit that referenced this pull request Oct 25, 2015
Two typos squashed.

BTW Let me know how to proceed with other typos if I ran across any. I don't feel well to leave them aside as much as sending pull requests with such tiny changes. Guide me.

Author: Jacek Laskowski <jacek.laskowski@deepsense.io>

Closes #9250 from jaceklaskowski/typos-hunting.

(cherry picked from commit 146da0d)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@asfgit asfgit closed this in 146da0d Oct 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants