[SPARK-11287] Fixed class name to properly start TestExecutor from deploy.client.TestClient

[BryanCutler]

Executing deploy.client.TestClient fails due to bad class name for TestExecutor in ApplicationDescription.

[JoshRosen]

Perhaps a naive question, but why not use classOf[TextExecutor].getCanonicalName so that this doesn't break in the future and is easier to grep with IntelliJ?

[BryanCutler]

I agree that would be better. Since TestExecutor is an object, it looks like I would have to use TestExecutor.getClass.getCanonicalName which returns "org.apache.spark.deploy.client.TestExecutor$" and then the $ would need to be removed.

So it's slightly more complicated, but still probably more future proof. Let me implement that and verify everything still works.

[SparkQA]

Test build #44239 has finished for PR 9255 at commit 4d0a593.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[BryanCutler]

test this please

[srowen]

Is the issue that it's missing "org.apache" or something -- does it cause a problem?

[BryanCutler]

Yes, it was missing "org.apache" and when running the TestClient, the master continuously tries and fails to start an executor.

[srowen]

Heh, I think this was just an oversight from the long-ago rename from spark.* to org.apache.spark.* as it exists in the initial revision: https://github.com/apache/spark/blob/46eecd110a4017ea0c86cbb1010d0ccd6a5eb2ef/core/src/main/scala/org/apache/spark/deploy/client/TestClient.scala

It does look like a typo, and I suppose this has just never been used ... ? probably virtually dead code but hey, let's just fix it.

[BryanCutler]

Haha, that's what I thought.. I must be the only one trying to run this code! But it did help me quickly test something, so it served some purpose :)

[SparkQA]

Test build #44250 has finished for PR 9255 at commit 1fab574.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #44254 has finished for PR 9255 at commit 1fab574.

• This patch fails PySpark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[SparkQA]

Test build #1955 has finished for PR 9255 at commit 1fab574.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

Merged to master/1.5