-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-10186][SQL] support postgre array type in JDBCRDD #9662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @marmbrus |
|
Test build #45737 has finished for PR 9662 at commit
|
|
I've added write support in #9137 as well if you want to just use it from there. |
|
Test build #45739 has finished for PR 9662 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that the same in all backends that support arrays (Oracle etc)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right, it's not always working
|
Test build #45742 has finished for PR 9662 at commit
|
|
These test failures don't seem to be related? |
|
retest this please |
|
Test build #45794 has finished for PR 9662 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a public API, if we add fields here we are going to break any existing implementations. Do we have to do this?
|
Test build #46050 has finished for PR 9662 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this just Literal.create(null, a.dataType)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yea, we can simply this.
|
Thanks, I'm going to merge this into master and 1.6. |
Add ARRAY support to `PostgresDialect`. Nested ARRAY is not allowed for now because it's hard to get the array dimension info. See http://stackoverflow.com/questions/16619113/how-to-get-array-base-type-in-postgres-via-jdbc Thanks for the initial work from mariusvniekerk ! Close #9137 Author: Wenchen Fan <wenchen@databricks.com> Closes #9662 from cloud-fan/postgre. (cherry picked from commit d925149) Signed-off-by: Michael Armbrust <michael@databricks.com>
Add ARRAY support to
PostgresDialect.Nested ARRAY is not allowed for now because it's hard to get the array dimension info. See http://stackoverflow.com/questions/16619113/how-to-get-array-base-type-in-postgres-via-jdbc
Thanks for the initial work from @mariusvniekerk !
Close #9137