-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-11390] [SQL] Query plan with/without filterPushdown indistinguishable #9679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets call it extraInformation in both places.
|
Can you fix the title / description so it doesn't truncate. Maybe add a test too so this doesn't get lost in refactoring. |
|
@marmbrus i was thinking about test cases, which sql/xxxSuite should this test case be added to? |
|
maybe sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala ? |
|
Changes to string formatting of Filter expr can break the test case. Did this recently change from "(key#27 = 15)" to "EqualTo(key,15)" ? |
|
@marmbrus is the PR good to go? |
|
ok to test |
|
Test build #45891 has finished for PR 9679 at commit
|
|
Test build #45900 has finished for PR 9679 at commit
|
|
Test build #45903 has finished for PR 9679 at commit
|
|
Test build #45960 has finished for PR 9679 at commit
|
…ishable Propagate pushed filters to PhyicalRDD in DataSourceStrategy.apply Add test case with parquet data source. Style fix. style fix Revert PhysicalRDD string formatting.
|
Test build #46011 has finished for PR 9679 at commit
|
|
Please merge. |
|
Thanks, merging to master and 1.6. |
…shable …ishable Propagate pushed filters to PhyicalRDD in DataSourceStrategy.apply Author: Zee Chen <zeechen@us.ibm.com> Closes #9679 from zeocio/spark-11390. (cherry picked from commit 985b38d) Signed-off-by: Michael Armbrust <michael@databricks.com>
…ishable
Propagate pushed filters to PhyicalRDD in DataSourceStrategy.apply