Skip to content

[SPARK-11736] [SQL] Add monotonically_increasing_id to function registry. #9703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yhuai wants to merge 2 commits into from
Closed

[SPARK-11736] [SQL] Add monotonically_increasing_id to function registry. #9703

yhuai wants to merge 2 commits into from

Conversation

@yhuai
Copy link
Contributor

@yhuai yhuai commented Nov 13, 2015

@SparkQA
Copy link

SparkQA commented Nov 13, 2015

Test build #45888 has finished for PR 9703 at commit d061442.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

rxin
rxin reviewed Nov 13, 2015
View reviewed changes
sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala Outdated
Copy link
Contributor

@rxin rxin Nov 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can just use expr("monotonically_increasing_id()") to simplify the test.

rxin
rxin reviewed Nov 15, 2015
View reviewed changes
sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala
Copy link
Contributor

@rxin rxin Nov 15, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was going to suggest just merging the two cases into one, but this works too.

@rxin
Copy link
Contributor

rxin commented Nov 15, 2015

LGTM

@SparkQA
Copy link

SparkQA commented Nov 15, 2015

Test build #45941 has finished for PR 9703 at commit bc4eb96.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Nov 15, 2015

I've merged this in master and branch-1.6.

@asfgit asfgit closed this in d83c2f9 Nov 15, 2015
asfgit pushed a commit that referenced this pull request Nov 15, 2015
@yhuai @rxin
[SPARK-11736][SQL] Add monotonically_increasing_id to function registry.
4a11e2d 
https://issues.apache.org/jira/browse/SPARK-11736

Author: Yin Huai <yhuai@databricks.com>

Closes #9703 from yhuai/MonotonicallyIncreasingID.

(cherry picked from commit d83c2f9)
Signed-off-by: Reynold Xin <rxin@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yhuai @SparkQA @rxin