[SPARK-11694][FOLLOW-UP] Clean up imports, use a common function for metadata and add a test for FIXED_LEN_BYTE_ARRAY #9754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…metadata and add a test for FIXED_LEN_BYTE_ARRAY
|
Test build #46046 has finished for PR 9754 at commit
|
Member
Author
|
I will cc you @liancheng just so that you can easily find :). |
Contributor
|
Thanks for cleaning this up! Merging to master. |
Contributor
|
@HyukjinKwon This PR doesn't merge cleanly with branch-1.6. Would you please file another PR to backport this change to branch-1.6? Thanks! |
Member
Author
|
yes I will! |
HyukjinKwon
added a commit
to HyukjinKwon/spark
that referenced
this pull request
Nov 17, 2015
This was referenced Nov 17, 2015
asfgit
pushed a commit
that referenced
this pull request
Nov 17, 2015
The main purpose of this PR is to backport #9754 I added several commits but they are identical with the PR. I will cc liancheng just to find this easily. Author: hyukjinkwon <gurwls223@gmail.com> Author: HyukjinKwon <gurwls223@gmail.com> Closes #9763 from HyukjinKwon/SPARK-11694-followup-backporting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed #9660 #9060, I cleaned up unused imports, added a test for fixed-length byte array and used a common function for writing metadata for Parquet.
For the test for fixed-length byte array, I have tested and checked the encoding types with parquet-tools.