Skip to content

Conversation

@holdenk
Copy link
Contributor

@holdenk holdenk commented Nov 17, 2015

When we exceed the max memory tell users to increase both params instead of just the one.

@SparkQA
Copy link

SparkQA commented Nov 17, 2015

Test build #46057 has finished for PR 9758 at commit 4e530a1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"and/or"? it could really be due to either one -- the max the scheduler will schedule, or the limit on the max size of a container. It may not need an increase in both.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, it would definitely and/or.. but I kind of question why we need this at all? The scheduler max is really what its compared to. If your nodemanagers aren't configured to have enough memory to meet that then I would say you have misconfigured your cluster. I'm fine with leaving the error in there if people fine is useful but I agree with @srowen I think this should be reworded to say something like check the values of ... rather then please increase the values.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've switched it to and/or + check the values. I think its a useful error for people trying to run Spark on YARN who might not know what the configuration params are they need here (much better than the alternative of dumping a stack trace to nowhere in particular).

@SparkQA
Copy link

SparkQA commented Nov 17, 2015

Test build #46120 has finished for PR 9758 at commit 5e38c39.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 17, 2015

Test build #46121 has finished for PR 9758 at commit 9125fcf.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@andrewor14
Copy link
Contributor

OK, merging into master 1.6

asfgit pushed a commit that referenced this pull request Nov 17, 2015
…two params have both in error msg

When we exceed the max memory tell users to increase both params instead of just the one.

Author: Holden Karau <holden@us.ibm.com>

Closes #9758 from holdenk/SPARK-11771-maximum-memory-in-yarn-is-controlled-by-two-params-have-both-in-error-msg.

(cherry picked from commit 52c734b)
Signed-off-by: Andrew Or <andrew@databricks.com>
@asfgit asfgit closed this in 52c734b Nov 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants