-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-11771][YARN][TRIVIAL] maximum memory in yarn is controlled by two params have both in error msg #9758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…eeding memory allocation
|
Test build #46057 has finished for PR 9758 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"and/or"? it could really be due to either one -- the max the scheduler will schedule, or the limit on the max size of a container. It may not need an increase in both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, it would definitely and/or.. but I kind of question why we need this at all? The scheduler max is really what its compared to. If your nodemanagers aren't configured to have enough memory to meet that then I would say you have misconfigured your cluster. I'm fine with leaving the error in there if people fine is useful but I agree with @srowen I think this should be reworded to say something like check the values of ... rather then please increase the values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've switched it to and/or + check the values. I think its a useful error for people trying to run Spark on YARN who might not know what the configuration params are they need here (much better than the alternative of dumping a stack trace to nowhere in particular).
|
Test build #46120 has finished for PR 9758 at commit
|
|
Test build #46121 has finished for PR 9758 at commit
|
|
OK, merging into master 1.6 |
…two params have both in error msg When we exceed the max memory tell users to increase both params instead of just the one. Author: Holden Karau <holden@us.ibm.com> Closes #9758 from holdenk/SPARK-11771-maximum-memory-in-yarn-is-controlled-by-two-params-have-both-in-error-msg. (cherry picked from commit 52c734b) Signed-off-by: Andrew Or <andrew@databricks.com>
When we exceed the max memory tell users to increase both params instead of just the one.