-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-11636][SQL] Support classes defined in the REPL with Encoders #9825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 95cec7d.
|
Test build #46276 has finished for PR 9825 at commit
|
|
test this please |
|
Test build #46295 has finished for PR 9825 at commit
|
|
Test build #46304 has finished for PR 9825 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not get this test to fail without this patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I can see it failing now both in scala 2.10 and 2.11.
I will spend more time to understand, if it is possible to fix it in some other way.
Try to make ExecutorClassLoader work.
|
I think we should include this in 1.6 -- otherwise there is no way for users to use datasets in the repl. |
|
+1 |
|
Test build #46438 has finished for PR 9825 at commit
|
#theScaryParts (i.e. changes to the repl, executor classloaders and codegen)... Author: Michael Armbrust <michael@databricks.com> Author: Yin Huai <yhuai@databricks.com> Closes #9825 from marmbrus/dataset-replClasses2. (cherry picked from commit 4b84c72) Signed-off-by: Michael Armbrust <michael@databricks.com>
|
Thanks, merging to master and 1.6 |
theScaryParts (i.e. changes to the repl, executor classloaders and codegen)...