Skip to content

Conversation

@marmbrus
Copy link
Contributor

theScaryParts (i.e. changes to the repl, executor classloaders and codegen)...

This reverts commit 95cec7d.
@SparkQA
Copy link

SparkQA commented Nov 19, 2015

Test build #46276 has finished for PR 9825 at commit 4428edd.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public final class UnsafeSorterSpillReader extends UnsafeSorterIterator implements Closeable\n * class CountVectorizerModelWriter(instance: CountVectorizerModel) extends Writer\n * final class IDF(override val uid: String) extends Estimator[IDFModel] with IDFBase with Writable\n * class MinMaxScalerModelWriter(instance: MinMaxScalerModel) extends Writer\n * class StandardScalerModelWriter(instance: StandardScalerModel) extends Writer\n * class StringIndexModelWriter(instance: StringIndexerModel) extends Writer\n * |class $\n * trait ScalaReflection\n * case class Schema(dataType: DataType, nullable: Boolean)\n * s\"Unable to generate an encoder for inner class$\n *case class EncodeUsingSerializer(child: Expression, kryo: Boolean) extends UnaryExpression \n *case class DecodeUsingSerializer[T](child: Expression, tag: ClassTag[T], kryo: Boolean)`\n

@marmbrus
Copy link
Contributor Author

test this please

@SparkQA
Copy link

SparkQA commented Nov 19, 2015

Test build #46295 has finished for PR 9825 at commit 4428edd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * |class $\n

@SparkQA
Copy link

SparkQA commented Nov 19, 2015

Test build #46304 has finished for PR 9825 at commit 57a3367.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * |class $\n

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not get this test to fail without this patch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test case only fails on partial applications of this patch. In particular with the classloader change here without the clasloader hack here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I can see it failing now both in scala 2.10 and 2.11.

I will spend more time to understand, if it is possible to fix it in some other way.

@rxin
Copy link
Contributor

rxin commented Nov 20, 2015

I think we should include this in 1.6 -- otherwise there is no way for users to use datasets in the repl.

@yhuai
Copy link
Contributor

yhuai commented Nov 20, 2015

+1

@SparkQA
Copy link

SparkQA commented Nov 20, 2015

Test build #46438 has finished for PR 9825 at commit 671fe53.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * |class $\n

asfgit pushed a commit that referenced this pull request Nov 20, 2015
#theScaryParts (i.e. changes to the repl, executor classloaders and codegen)...

Author: Michael Armbrust <michael@databricks.com>
Author: Yin Huai <yhuai@databricks.com>

Closes #9825 from marmbrus/dataset-replClasses2.

(cherry picked from commit 4b84c72)
Signed-off-by: Michael Armbrust <michael@databricks.com>
@marmbrus
Copy link
Contributor Author

Thanks, merging to master and 1.6

@asfgit asfgit closed this in 4b84c72 Nov 20, 2015
@marmbrus marmbrus deleted the dataset-replClasses2 branch March 8, 2016 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants