[SPARK-6791] [ML] Add read/write for CrossValidator and Evaluators #9848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #46369 has finished for PR 9848 at commit
|
jkbradley
changed the title
Member
Author
|
@mengxr @yanboliang Ready for review! |
|
Test build #46394 has finished for PR 9848 at commit
|
Contributor
There was a problem hiding this comment.
Minor: organize imports
Contributor
|
LGTM for me. |
Contributor
There was a problem hiding this comment.
Shall we add checks for OneVSRest and other meta-algorithms? It is okay to create a JIRA and leave a TODO here.
Contributor
|
Made one pass. |
…her metadata. Cleanups to CrossValidator save/load based on code review. Refactoring to eliminate some duplicate code.
Member
Author
|
OK, I believe that addressed everything. This includes a little refactoring to make sure callers to the default metadata save/load methods are using them correctly (and it eliminates some duplicate code). |
|
Test build #46464 has finished for PR 9848 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Nov 23, 2015
I believe this works for general estimators within CrossValidator, including compound estimators. (See the complex unit test.) Added read/write for all 3 Evaluators as well. CC: mengxr yanboliang Author: Joseph K. Bradley <joseph@databricks.com> Closes #9848 from jkbradley/cv-io. (cherry picked from commit a6fda0b) Signed-off-by: Xiangrui Meng <meng@databricks.com>
Contributor
|
LGTM. Merged into master and branch-1.6. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this works for general estimators within CrossValidator, including compound estimators. (See the complex unit test.)
Added read/write for all 3 Evaluators as well.
CC: @mengxr @yanboliang