Skip to content

Conversation

@nongli
Copy link
Contributor

@nongli nongli commented Nov 24, 2015

The issue is that the output commiter is not idempotent and retry attempts will
fail because the output file already exists. It is not safe to clean up the file
as this output committer is by design not retryable. Currently, the job fails
with a confusing file exists error. This patch is a stop gap to tell the user
to look at the top of the error log for the proper message.

This is difficult to test locally as Spark is hardcoded not to retry. Manually
verified by upping the retry attempts.

@marmbrus
Copy link
Contributor

add to whitelist

@SparkQA
Copy link

SparkQA commented Nov 24, 2015

Test build #46619 has finished for PR 9942 at commit d19b5c3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove this line, scala will throw un-catched exception

nongli and others added 2 commits November 30, 2015 12:48
The issue is that the output commiter is not idempotent and retry attempts will
fail because the output file already exists. It is not safe to clean up the file
as this output committer is by design not retryable. Currently, the job fails
with a confusing file exists error. This patch is a stop gap to tell the user
to look at the top of the error log for the proper message.

This is difficult to test locally as Spark is hardcoded not to retry. Manually
verified by upping the retry attempts.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

earlier logs => earlier logs or stage page?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yhuai
Copy link
Contributor

yhuai commented Nov 30, 2015

Seems the jira number is not the right one?

@yhuai
Copy link
Contributor

yhuai commented Nov 30, 2015

ah it is actually https://issues.apache.org/jira/browse/SPARK-11328

@nongli nongli changed the title [SPARK-11382] [SQL] Improve error message when hitting this issue. [SPARK-11328] [SQL] Improve error message when hitting this issue. Nov 30, 2015
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be its better idea to wrap current exception instance into SparkException
Example: SparkException("some error message", e)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I explicitly did not do that because that makes it really seem like the root cause is "file already exists". This error would be in the middle of a big stack trace. We can go either way though.

@nongli nongli closed this Dec 1, 2015
@nongli nongli deleted the spark-11328-fix branch December 1, 2015 21:48
@nongli nongli restored the spark-11328-fix branch December 1, 2015 22:25
@SparkQA
Copy link

SparkQA commented Dec 1, 2015

Test build #46989 has finished for PR 9942 at commit c4375ec.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * class ChainedIterator extends UnsafeSorterIterator\n * class UnsafeCartesianRDD(left : RDD[UnsafeRow], right : RDD[UnsafeRow], numFieldsOfRight: Int)\n

@nongli nongli deleted the spark-11328-fix branch December 2, 2015 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants