Skip to content

[SPARK-11989][SQL] Only use commit in JDBC data source if the underlying database supports transactions #9973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CK50 wants to merge 10 commits into from
Closed

[SPARK-11989][SQL] Only use commit in JDBC data source if the underlying database supports transactions #9973

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0b9ea1a
Initial version of support for non-transactional databases/ drivers
CK50 Nov 24, 2015
8e415d8
Address Sean's code review comments
CK50 Nov 25, 2015
d109035
Sorry for the accidental test code!
CK50 Nov 25, 2015
40fe0a7
included suggested changes
CK50 Nov 25, 2015
dd1c0d9
Added warning message for any exception when detecting transaction su…
CK50 Nov 25, 2015
7288552
Added logging
CK50 Nov 25, 2015
6a1220b
Corrected msg
CK50 Nov 25, 2015
c2a17ed
Included Reynolds last comments
CK50 Nov 26, 2015
00ed367
updated
CK50 Nov 26, 2015
9e5ffe6
Trailing whitespaces removed
CK50 Nov 27, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import java.sql.{Connection, PreparedStatement}
import java.util.Properties

import scala.util.Try
import scala.util.control.NonFatal

import org.apache.spark.Logging
import org.apache.spark.sql.jdbc.{JdbcDialect, JdbcType, JdbcDialects}
Expand Down Expand Up @@ -125,8 +126,19 @@ object JdbcUtils extends Logging {
dialect: JdbcDialect): Iterator[Byte] = {
val conn = getConnection()
var committed = false
val supportsTransactions = try {
conn.getMetaData().supportsDataManipulationTransactionsOnly() ||
conn.getMetaData().supportsDataDefinitionAndDataManipulationTransactions()
} catch {
case NonFatal(e) =>
logWarning("Exception while detecting transaction support", e)
true
}

try {
conn.setAutoCommit(false) // Everything in the same db transaction.
if (supportsTransactions) {
conn.setAutoCommit(false) // Everything in the same db transaction.
}
val stmt = insertStatement(conn, table, rddSchema)
try {
var rowCount = 0
Expand Down Expand Up @@ -175,14 +187,18 @@ object JdbcUtils extends Logging {
} finally {
stmt.close()
}
conn.commit()
if (supportsTransactions) {
conn.commit()
Copy link
Member

@gatorsmile gatorsmile Oct 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still wrong... The commit is partition level.

Copy link
Member

@gatorsmile gatorsmile Oct 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the dataFrame has duplicate keys and the target tables have the unique constraints, we could see the non-deterministic results at the target tables, since some partitions containing duplicate keys could be rolled back.

}
committed = true
} finally {
if (!committed) {
// The stage must fail. We got here through an exception path, so
// let the exception through unless rollback() or close() want to
// tell the user about another problem.
conn.rollback()
if (supportsTransactions) {
conn.rollback()
}
conn.close()
} else {
// The stage must succeed. We cannot propagate any exception close() might throw.
Expand Down