-
Notifications
You must be signed in to change notification settings - Fork 587
SQOOP-3427 Add Travis badge to the README #71
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Fokko,
Thanks for submitting this patch!
Could you remove the old README.txt file as well so we don't duplicate information?
(Or do you think we should keep it?)
In any case, badges are awesome!
Thanks for looking into this @fszabo2 I've removed the old README. I think we should get rid of it since it is almost the same as the new one. |
I also took the liberty to include Koen's work in #31 into this PR. |
Hi @Fokko, Sorry for my late responses, I have quite limited bandwidth these days for Sqoop. Anyway, could you please rebase this on the current trunk, so we can see if your fix for the CI took effect? |
Thanks for taking the time. I've rebased the PR. Probably I'll do a couple of more PR's in the upcoming days to fix the compiler warnings, make better use of try-with-resources and bumping some of the dependencies to fix security issues. |
Hi @Fokko, I have submitted a PR for your branch with my suggestions: https://github.com/Fokko/sqoop/pull/1/files |
Thanks @szvasas Sorry for taking so long, I was a bit busy lately. |
We all love badges: https://jira.apache.org/jira/browse/SQOOP-3427