Skip to content
This repository was archived by the owner on Jul 9, 2021. It is now read-only.

SQOOP-3427 Add Travis badge to the README #71

Merged
merged 9 commits into from
Mar 18, 2019
Merged

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Feb 21, 2019

Copy link
Contributor

@fszabo2 fszabo2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Fokko,

Thanks for submitting this patch!
Could you remove the old README.txt file as well so we don't duplicate information?
(Or do you think we should keep it?)

In any case, badges are awesome!

@Fokko
Copy link
Contributor Author

Fokko commented Mar 4, 2019

Thanks for looking into this @fszabo2

I've removed the old README. I think we should get rid of it since it is almost the same as the new one.

@Fokko
Copy link
Contributor Author

Fokko commented Mar 5, 2019

I also took the liberty to include Koen's work in #31 into this PR.

@fszabo2
Copy link
Contributor

fszabo2 commented Mar 8, 2019

Hi @Fokko,

Sorry for my late responses, I have quite limited bandwidth these days for Sqoop.

Anyway, could you please rebase this on the current trunk, so we can see if your fix for the CI took effect?

@Fokko
Copy link
Contributor Author

Fokko commented Mar 9, 2019

Thanks for taking the time. I've rebased the PR.

Probably I'll do a couple of more PR's in the upcoming days to fix the compiler warnings, make better use of try-with-resources and bumping some of the dependencies to fix security issues.

@szvasas
Copy link
Contributor

szvasas commented Mar 13, 2019

Hi @Fokko,

I have submitted a PR for your branch with my suggestions: https://github.com/Fokko/sqoop/pull/1/files
I basically renamed COMPILING.txt to COMPILING.adoc so GitHub will format it by default and I refer it from README.md.

@Fokko
Copy link
Contributor Author

Fokko commented Mar 17, 2019

Thanks @szvasas

Sorry for taking so long, I was a bit busy lately.

@szvasas szvasas merged commit 0216f7f into apache:trunk Mar 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants