Skip to content

[STORM-1501] launch worker process exception will cause supervisor process exited #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
caofangkun wants to merge 2 commits into from
Closed

[STORM-1501] launch worker process exception will cause supervisor process exited #1046

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21ef59c
[STORM-1501] launch worker process exception will cause supervisor pr…
caofangkun Jan 26, 2016
1b1c776
[STORM-1501] launch worker process exception will cause supervisor pr…
caofangkun Jan 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion storm-core/src/clj/org/apache/storm/util.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,8 @@
(catch InterruptedException e
(log-message log-prefix " interrupted.")))
(exit-code-callback (.exitValue process)))
nil)))
nil)
:kill-fn (fn [error] (log-error (RuntimeException. ("launch process failed..."))))))
Copy link
Contributor

@revans2 revans2 Jan 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we throwing away error?

What happens if this does not exit? I assume that the heartbeat monitoring will detect it and do the right thing, but are there other places in the code besides a worker process that we use this? Will there be problems especially around the exit-code-callback if they are not called?

process)))

(defn exists-file?
Expand Down