Skip to content

fallbacks to startoffset time if offset is out of range #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kaustubhpriye wants to merge 2 commits into from
Closed

fallbacks to startoffset time if offset is out of range #1268

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63cb041
fallbacks to startoffset time if offset is out of range
kaustubhpriye Mar 27, 2016
93c9189
fallbcaking on next offset if the offset is within range
kaustubhpriye Mar 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions external/storm-kafka/src/jvm/storm/kafka/trident/TridentKafkaEmitter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import backtype.storm.metric.api.ReducedMetric;
import backtype.storm.task.TopologyContext;
import com.google.common.collect.ImmutableMap;
import kafka.api.OffsetRequest;
import kafka.javaapi.consumer.SimpleConsumer;
import kafka.javaapi.message.ByteBufferMessageSet;
import kafka.message.Message;
Expand Down Expand Up @@ -104,6 +105,14 @@ private Map doEmitNewPartitionBatch(SimpleConsumer consumer, Partition partition
}
if (_config.forceFromStart && !_topologyInstanceId.equals(lastInstanceId)) {
offset = KafkaUtils.getOffset(consumer, _config.topic, partition.partition, _config.startOffsetTime);
if(_config.useStartOffsetTimeIfOffsetOutOfRange){
long nextOffset = (Long) lastMeta.get("nextOffset");
long earliestAvailableOffset = KafkaUtils.getOffset(consumer, _config.topic, partition.partition, OffsetRequest.EarliestTime());
long latestAvailableOffset = KafkaUtils.getOffset(consumer, _config.topic, partition.partition, OffsetRequest.LatestTime());
if(earliestAvailableOffset <= nextOffset && nextOffset <= latestAvailableOffset) { // in the offset range.
offset = nextOffset;
}
}
} else {
offset = (Long) lastMeta.get("nextOffset");
}
Expand Down