-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[STORM-1544] Document Debug/Sampling of Topologies #1269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
+1 |
|
It looks good can we add a link to this in docs/index.md as well? Otherwise it will not be easy to find in the UI. |
|
@revans2 The yaml front matter +1 |
|
@ptgoetz Not for the release specific docs. At least I didn't end up setting it up that way, and so if I missed something, then I am happy to go back and try and fix it. |
|
@revans2 Okay. I didn't realize that had changed, I'm okay with either approach. One thing I did notice is that the documentation dropdown is missing from the home page, and the downloads page is now a 404. (sorry for hijacking this pull request) |
|
@ptgoetz I didn't realize that we were generating an index using the docs tag. I am happy to go back and add something in again for it. Also everything is working fine for me. what browser are you using? is there something in your cache that is messed up? Just FYI I renamed the download.html to releases.html, because it includes more then just download links, but the download button points to the proper place. I am happy to revert that change too if you had other stuff pointing to it. |
|
@revans2 we should add redirection from downloads.html to release.html. |
|
@revans2 It was a caching issue. Sorry for the noise. I agree with @harshach, we may want to consider a redirect from downloads.html to release.html to keep from breaking external links and bookmarks. I think we need to add a link to the KEYS file for releases, and it might help to add maven information like we did in the old downloads page. |
Added documentation for logging/sampling events in a topology.
9dfe488 to
0969556
Compare
|
+1 again. |
|
Appears that some html pages are broken. E.g. http://storm.apache.org/releases/1.0.0-SNAPSHOT/State-checkpointing.html beyond the section "IStateful bolt hooks", the formatting and sections headings are lost. Do we need to fix something in the scripts that generate the html files ? |
|
@arunmahadevan That's likely a typo or formatting error in the markdown file. |
|
@ptgoetz updated the doc to reflect the new (disabled by default) behavior. Please review. |
|
+1 |
STORM-3259: NUMA Support for Storm
Added documentation for logging/sampling events in a topology.