Skip to content

[STORM-1883] FileReader extends Closeable Interface #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
darionyaphet wants to merge 1 commit into from
Closed

[STORM-1883] FileReader extends Closeable Interface #1462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions external/storm-hdfs/src/main/java/org/apache/storm/hdfs/spout/FileReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,11 @@

import org.apache.hadoop.fs.Path;

import java.io.Closeable;
import java.io.IOException;
import java.util.List;

interface FileReader {
interface FileReader extends Closeable {
Path getFilePath();

/**
Expand All @@ -40,5 +41,4 @@ interface FileReader {
*/
List<Object> next() throws IOException, ParseException;

void close();
}
6 changes: 5 additions & 1 deletion external/storm-hdfs/src/main/java/org/apache/storm/hdfs/spout/HdfsSpout.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,11 @@ private void closeReaderAndResetTrackers() {
tracker.offsets.clear();
retryList.clear();

reader.close();
try {
reader.close();
} catch (IOException e) {
LOG.error("File Closing Failed", e);
}
reader = null;
releaseLockAndLog(lock, spoutId);
lock = null;
Expand Down